Skip to content

Update RemoteDistDataset methods to use fetch_ prefix. #511

Merged
kmontemayor2-sc merged 5 commits intomainfrom
kmonte/update-rdi-naming
Feb 25, 2026
Merged

Update RemoteDistDataset methods to use fetch_ prefix. #511
kmontemayor2-sc merged 5 commits intomainfrom
kmonte/update-rdi-naming

Conversation

@kmontemayor2-sc
Copy link
Collaborator

Scope of work done

As discussed in https://github.com/Snapchat/GiGL/pull/510/changes#r2848163439 we should make the naming more distinct. Choosing to go with fetch_ as it signifies a remote call (imo).

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

@kmontemayor2-sc
Copy link
Collaborator Author

/all_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 01:25:26UTC : 🔄 Scala Unit Test started.

@ 01:32:59UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 01:25:26UTC : 🔄 Python Unit Test started.

@ 02:41:11UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 01:25:29UTC : 🔄 Lint Test started.

@ 01:32:05UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 01:25:30UTC : 🔄 E2E Test started.

@ 02:49:30UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 01:25:30UTC : 🔄 Integration Test started.

@ 02:54:54UTC : ✅ Workflow completed successfully.

Copy link
Collaborator

@mkolodner-sc mkolodner-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Very helpful for distinguishing what is called on the client vs the server from the function name :)

@kmontemayor2-sc
Copy link
Collaborator Author

/all_test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 16:39:59UTC : 🔄 E2E Test started.

@ 18:09:58UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 16:40:00UTC : 🔄 Lint Test started.

@ 16:46:36UTC : ❌ Workflow failed.
Please check the logs for more details.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 16:40:00UTC : 🔄 Integration Test started.

@ 18:05:26UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 16:40:00UTC : 🔄 Scala Unit Test started.

@ 16:49:12UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

GiGL Automation

@ 16:40:02UTC : 🔄 Python Unit Test started.

@ 17:52:35UTC : ✅ Workflow completed successfully.

@kmontemayor2-sc kmontemayor2-sc marked this pull request as ready for review February 25, 2026 17:48
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Feb 25, 2026
@kmontemayor2-sc kmontemayor2-sc removed this pull request from the merge queue due to a manual request Feb 25, 2026
@kmontemayor2-sc kmontemayor2-sc added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit 2590a8c Feb 25, 2026
6 checks passed
@kmontemayor2-sc kmontemayor2-sc deleted the kmonte/update-rdi-naming branch February 25, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants