Update RemoteDistDataset methods to use fetch_ prefix. #511
Update RemoteDistDataset methods to use fetch_ prefix. #511kmontemayor2-sc merged 5 commits intomainfrom
RemoteDistDataset methods to use fetch_ prefix. #511Conversation
|
/all_test |
GiGL Automation@ 01:25:26UTC : 🔄 @ 01:32:59UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 01:25:26UTC : 🔄 @ 02:41:11UTC : ❌ Workflow failed. |
GiGL Automation@ 01:25:29UTC : 🔄 @ 01:32:05UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 01:25:30UTC : 🔄 @ 02:49:30UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 01:25:30UTC : 🔄 @ 02:54:54UTC : ✅ Workflow completed successfully. |
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks a lot! Very helpful for distinguishing what is called on the client vs the server from the function name :)
|
/all_test |
GiGL Automation@ 16:39:59UTC : 🔄 @ 18:09:58UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 16:40:00UTC : 🔄 @ 16:46:36UTC : ❌ Workflow failed. |
GiGL Automation@ 16:40:00UTC : 🔄 @ 18:05:26UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 16:40:00UTC : 🔄 @ 16:49:12UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 16:40:02UTC : 🔄 @ 17:52:35UTC : ✅ Workflow completed successfully. |
Scope of work done
As discussed in https://github.com/Snapchat/GiGL/pull/510/changes#r2848163439 we should make the naming more distinct. Choosing to go with
fetch_as it signifies a remote call (imo).Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO