Skip to content

fix: resolve GitHub OAuth 404 by adding frontend fallback (#821)#1393

Open
wingo-blue wants to merge 4 commits into
SolFoundry:mainfrom
wingo-blue:feat/fix-github-oauth-821
Open

fix: resolve GitHub OAuth 404 by adding frontend fallback (#821)#1393
wingo-blue wants to merge 4 commits into
SolFoundry:mainfrom
wingo-blue:feat/fix-github-oauth-821

Conversation

@wingo-blue

Copy link
Copy Markdown

Summary

Fix the GitHub OAuth sign-in flow that returns 404 when users click 'Sign in with GitHub'.

Root Cause

The frontend calls /api/auth/github/authorize\ on the backend, which returns 404 (backend is in a separate private repo). The existing fallback redirected to the same 404 endpoint.

Changes

  • auth.ts - Add VITE_GITHUB_CLIENT_ID env var fallback, CSRF state generation, sessionStorage verification
  • AuthGuard.tsx - Replace broken 404 fallback with proper error message
  • GitHubCallbackPage.tsx - OAuth state validation, user-friendly error page, error state with retry
  • .env.example - Add VITE_GITHUB_CLIENT_ID placeholder

Closes #821

Wallet: A6YMFucCab3KvqLxHAtaUFxFUReSTPUg4dTxn1kQy7t

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🏭 Bounty T1: Fix GitHub OAuth Sign-In Flow

1 participant