Skip to content

feat/96-folders - #274

Open
olios123 wants to merge 40 commits into
devfrom
feat/96-folders
Open

feat/96-folders#274
olios123 wants to merge 40 commits into
devfrom
feat/96-folders

Conversation

@olios123

@olios123 olios123 commented Jun 4, 2026

Copy link
Copy Markdown
Member

TODO

@solvro-ci

solvro-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown

The preview deployment for frontend-testownik-dev is ready. 🟢

Open Preview | Open Build Logs | Open Application Logs

Last updated at: 2026-06-28 18:08:05 CET

@olios123
olios123 marked this pull request as draft June 4, 2026 19:33
This was linked to issues Jun 4, 2026
@olios123

olios123 commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

@olios123

olios123 commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@Antoni-Czaplicki puścisz my review od Copilota bo mi się creditsy skończyły ? XD

@Antoni-Czaplicki

Copy link
Copy Markdown
Member

same ale zaraz ci puszcze

@Antoni-Czaplicki Antoni-Czaplicki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI review] I found a few correctness issues in the folder-library refactor that should be addressed before merging.

Comment thread src/types/quiz.ts Outdated
Comment thread src/app/quizzes/client.tsx
Comment thread src/app/quizzes/client.tsx
Comment thread src/app/quizzes/client.tsx
@olios123
olios123 marked this pull request as ready for review June 9, 2026 12:21
@olios123
olios123 requested a review from Antoni-Czaplicki June 9, 2026 12:22

@Antoni-Czaplicki Antoni-Czaplicki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

AI-generated review comment.

I reviewed the folder-library PR against current dev, including the new services/hooks, dashboard rendering, drag-and-drop move flows, archive behavior, query cache invalidation, type surface, and local checks.

Main blockers:

  • The PR is currently not mergeable. GitHub reports it as CONFLICTING, with dependency lockfile conflicts needing resolution.
  • pnpm typecheck fails after pnpm next typegen because folder is now required on QuizBase but existing quiz fixtures/local objects omit it.
  • Shared quiz rendering, search/filtering in folder views, and folder-library cache invalidation have user-visible regressions called out inline.

Checks: pnpm test --run --testTimeout=15000 passes (70/70), but typecheck does not.

Needed to merge: resolve the current dev conflicts, make typecheck clean, fix shared-tab rendering, apply search to folder/library contents, invalidate or update all affected folder-library caches after archive/move/delete/rename flows, and add regression coverage for shared quizzes, search inside folder views, archive invalidation, and moving into a cached destination folder.

Comment thread src/components/quiz/quiz-library.tsx
Comment thread src/app/quizzes/client.tsx
Comment thread src/app/quizzes/client.tsx Outdated
Comment thread src/app/quizzes/client.tsx
Comment thread src/types/quiz.ts
olios123 added 16 commits June 28, 2026 18:53
…nced functionality

# Conflicts:
#	pnpm-lock.yaml
…and delete functionality

# Conflicts:
#	src/app/quizzes/client.tsx
olios123 and others added 24 commits June 28, 2026 19:01
* feat: start implementing statistics and update quiz types

* feat: refactor quiz loading logic and introduce custom useQuiz hook

* feat: clean up deprecated components and improve eslint rules in AI explain card and reasoning

* feat: add quiz statistics charts and related components for enhanced data visualization

* feat: enhance quiz statistics functionality with improved data fetching and tooltip components

* feat: enhance quiz statistics functionality with improved data fetching and tooltip components

* feat: update chart components with improved styling and add metric descriptions for better clarity

* feat: enhance quiz bug reporting and statistics querying with improved data handling and query keys
# Conflicts:
#	src/app/quizzes/client.tsx
@Antoni-Czaplicki
Antoni-Czaplicki force-pushed the dev branch 2 times, most recently from eaddd9b to f57961b Compare July 1, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Folder usuniętch Foldery quizów

2 participants