Fix ITs Step #504
Merged
Fix ITs Step #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-vinot-sonarsource
force-pushed
the
avi/fix-its-step
branch
from
a6a94ba to
b5297c6
Compare
antoine-vinot-sonarsource
force-pushed
the
avi/fix-its-step
branch
2 times, most recently
from
e626cb6 to
1507648
Compare
antoine-vinot-sonarsource
requested a review
from claire-villard-sonarsource
antoine-vinot-sonarsource
force-pushed
the
avi/fix-its-step
branch
from
1507648 to
406f6d7
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new workflow we are now updating package.json before generating and running the ITs.
So the
git diff stepwas failing on master because theconfig-npmaction modifies package.json to include the build number (on master only)