SLCORE-1845 Enable the new database globally #1587
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damien-urruty-sonarsource
force-pushed
the
task/dam/SLCORE-1819-migration
branch
from
ef9e980 to
08fffa1
Compare
damien-urruty-sonarsource
force-pushed
the
task/dam/SLCORE-1845-enable-h2-globally
branch
6 times, most recently
from
71936b4 to
e3c4d11
Compare
damien-urruty-sonarsource
force-pushed
the
task/dam/SLCORE-1819-migration
branch
from
08fffa1 to
02e9b7b
Compare
damien-urruty-sonarsource
force-pushed
the
task/dam/SLCORE-1845-enable-h2-globally
branch
from
e3c4d11 to
4367e3e
Compare
damien-urruty-sonarsource
force-pushed
the
task/dam/SLCORE-1845-enable-h2-globally
branch
5 times, most recently
from
225f0d7 to
e4c925a
Compare
damien-urruty-sonarsource
requested review from
kirill-knize-sonarsource and
vnaskos-sonar
Contributor
Author
|
hi @vnaskos-sonar, could you give this a look? The PR is quite big, sorry, but it's mostly due to the Xodus removal. There are 3 changes:
If you're too busy, I think this can also wait tomorrow |
damien-urruty-sonarsource
force-pushed
the
task/dam/SLCORE-1845-enable-h2-globally
branch
from
e4c925a to
bc3b030
Compare
|
backend/core/src/main/java/org/sonarsource/sonarlint/core/issue/IssueService.java
Show resolved
Hide resolved
kirill-knize-sonarsource
approved these changes
Nov 28, 2025
Contributor
kirill-knize-sonarsource
left a comment
kirill-knize-sonarsource
left a comment
There was a problem hiding this comment.
Minor typos inherited from previous implementation, else LGTM
| taintIssueEntity.setLink("branch", branchEntity); | ||
| } | ||
|
|
||
| public static InputStream toProtoFlow(List<ServerTaintIssue.Flow> flows) { |
Contributor
There was a problem hiding this comment.
toProtoFlows?
| return new ByteArrayInputStream(buffer.toByteArray()); | ||
| } | ||
|
|
||
| public static InputStream toProtoImpact(Map<SoftwareQuality, ImpactSeverity> impacts) { |
Contributor
There was a problem hiding this comment.
toProtoImpacts
vnaskos-sonar
approved these changes
Nov 28, 2025
Contributor
vnaskos-sonar
left a comment
vnaskos-sonar
left a comment
There was a problem hiding this comment.
I tested this SlCore version on VS and everything* seemed to work as expected. 👍
*everything:
- analysis of JS, TS, CPP, C#, VB.NET, HTML, Secrets
- Exclusions/Suppressions
- Connected mode
- Mark issue as resolved
- Hotspots
- Taints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.