More possibilities for gt generation #4289
Open
+85
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
samuelgarcia
reviewed
Jan 5, 2026
| else: | ||
| num_units = sorting.get_num_units() | ||
| sampling_frequency = sorting.sampling_frequency | ||
| if sorting._recording is not None: |
Member
There was a problem hiding this comment.
This is very strange. Why would the sorting have an attached recording, we want to generate it.
Collaborator
Author
There was a problem hiding this comment.
Yes, but you can have a first generation, obtain a sorting, and then you might want to take the duration of this first data. But agreed, this might be not needed
samuelgarcia
reviewed
Jan 5, 2026
| duration, unit_locations[:, :2], seed=seed, **generate_displacement_vector_kwargs | ||
| ) | ||
| else: | ||
| ( |
Member
There was a problem hiding this comment.
I would make a dict no ? Or at least a named tuple.
Collaborator
Author
There was a problem hiding this comment.
I don't know, this was to be consistent, but I can make it a dict if you prefer
samuelgarcia
reviewed
Jan 5, 2026
| durations=[duration], | ||
| seed=seed, | ||
| **generate_noise_kwargs, | ||
| ) |
Member
There was a problem hiding this comment.
else:
we need to check the duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, one can not provide custom parameters to the drifting_gt generation. This PR fixes such behavior, such that users can not provide their own sorting, NoiseGenerator, Template kwargs, ... in order to reproduce more closely one behavior or refine benchmarks