Fix wrapping parenthesis filter parsing error #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the filter parser to correctly handle function comparisons within JSONPath expressions. Ensures that functions requiring comparison (e.g., length(@.title)) are properly validated and throw exceptions when used as standalone expressions without a comparison operator. This change prevents invalid filter expressions while allowing valid expressions with comparison operators (e.g., length(@.title) > 10). Also includes benchmark updates and minor cleanup.
Adds naming rule for type parameters. Streamlines the filter parser by removing unnecessary checks and improving character handling within quotes. This enhances efficiency and code clarity. The parser now throws an exception if a function that requires comparison is left as a standalone expression.
…fix-left-function-compare
Corrects the comparison logic in the filter parser to properly handle `CompareConstraint` flags using bitwise AND instead of `HasFlag()`, which can lead to boxing allocations. This improves performance and ensures accurate evaluation of filter expressions. Also optimizes the `OperatorExtensions` methods to use direct bitwise operations instead of `HasFlag()` for better performance. Replaces `Scalar.Value` with direct instantiation of `ScalarValue` to avoid unnecessary indirection. Updates the .gitignore to include baseline benchmark results. Removes the benchmark report markdown file and updates the benchmark to use pre-parsed `JsonDocument` for more accurate measurements.
…fix-left-function-compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wrapping parenthesis filter parsing error.
Type of Change
Checklist