Fix/offline mutation success and dynamic focus - #1499
Open
dorismaduegbunam wants to merge 2 commits into
Open
Conversation
…eampay-Org#1449) Block stream mutations while the browser reports offline and only present a success when the mutation response confirms the server-side state transition (data.status). Adds a connectivity hook and a fail-closed confirmation guard used by both the stream row and detail page. Also restores syntax corruption in PaymentTimeline, Timestamp, and ActivityTimeline (build-blocking defects from Streampay-Org#1480) required for tests to run.
…ls (Streampay-Org#1424) Move the palette combobox off inline outline suppression and JS focus styling onto the shared @layer focus rules, add a visible active-option ring for the aria-activedescendant listbox, and add Home/End navigation plus aria-autocomplete=list.
|
@dorismaduegbunam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Prevent offline mode from presenting stale mutation success (#1449)
Stream mutations (
start,pause,stop,settle,withdraw,cancel) previously presented a "success" whenever the request promise resolved, even if the browser was offline or the server never applied the transition. A stale or dropped request could surface as a successful mutation.useNetworkStatushook (navigator.onLine+online/offlineevents). While offline the mutation is never dispatched and an "Offline - action not applied" error is shown instead.data.status). A resolved-but-unconfirmed body is treated as failure ("Action not confirmed").Closes #1449
2. Add visible focus treatment for dynamic controls (#1424)
The CommandPalette combobox suppressed its native outline and relied on inline JS focus styling, and its
aria-activedescendantlistbox active option was distinguishable only by background tint — no visible focus ring for keyboard and assistive-technology users.@layer focusrules: a:focus-visibleaccent ring plus theme-safe suppression for mouse/touch focus.Home/Endnavigation andaria-autocomplete="list"for a complete combobox autocomplete pattern.Closes #1424