fix: make print styles omit secrets and interactive controls - #1500
Open
Fading-Dev wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes print output least-privilege by ensuring secrets and interactive controls are omitted from printed pages. Wallet addresses, copy controls, command palette, bottom navigation, theme toggle, and wallet modal triggers are hidden only in
@media print. The change is deterministic and stateless: screen rendering, wallet actions, and existing component APIs are unchanged, while print-specific CSS/classes anddata-print-*hooks provide a single enforcement layer that is reviewable and testable.Related Issue
Changes
🖨 Print-Style Secret & Control Omission
[ADD]
app/globals.css.print-noutility and@media printrules that applydisplay: none !importantto secret-bearing and interactive selectors.data-print-*attributes to avoid broad display changes.[MODIFY]
app/components/CopyAddress.tsx.print-no/data-print-hidden, so full and truncated addresses never appear in printed output.[MODIFY]
app/components/WalletBadge.tsx[MODIFY]
app/components/WalletModal.tsx[MODIFY]
app/components/CommandPalette.tsx[MODIFY]
app/components/BottomNav.tsx[MODIFY]
app/components/ThemeToggle.tsx[MODIFY]
app/layout.tsxdata-print-hidden/ print-safe wrappers around non-content root regions so no interactive shell is printed.[ADD]
app/__tests__/printStyles.test.tsVerification Results
Closes #1429