2회차 스터디 후 src/1week 리팩터링하기

src/1week/01.js

@@ -1,7 +1,7 @@
 var x = 2;
 
-function lineFunction() {
-  return 2 * x + 3;
+function lineFunction(xParam = x) {
+  return 2 * xParam + 3;
 }
 
 exports.lineFunction = lineFunction;

src/1week/02.js

@@ -1,11 +1,7 @@
-function accumulate(arr) {
-  let accumulator = 0;
-
-  for (let i = 0; i < arr.length; i++) {
-    accumulator += arr[i];
-  }
+const sum = (a, b) => a + b;
 
-  return accumulator;
+function accumulate(arr) {
+  return arr.reduce(sum, 0);
 }
 
 exports.accumulate = accumulate;

src/1week/03.js

@@ -1,10 +1,14 @@
-function multiDimensionalAccumulate(multiDimensionalArr) {
+function multiDimensionalArrayCondition ({row, column}) {
+  return column < row;
+}
+
+function multiDimensionalAccumulate(multiDimensionalArray) {
   let accumulator = 0;
 
-  for (let i = 0; i < multiDimensionalArr.length; i++) {
-    for (let j = 0; j < multiDimensionalArr[i].length; j++) {
-      if (j < i) {
-        accumulator += multiDimensionalArr[i][j];
+  for (let i = 0; i < multiDimensionalArray.length; i++) {
+    for (let j = 0; j < multiDimensionalArray[i].length; j++) {
+      if (multiDimensionalArrayCondition({row: i, column: j})) {
+        accumulator += multiDimensionalArray[i][j];
       }
     }
   }

src/1week/04.js

@@ -1,15 +1,17 @@
-function convertToConditionalUpperCase(words) {
-  let capitalized = [];
+function convertUpperCase(stringParam) {
+  return stringParam.toUpperCase();
+}
+
+function convertLowerCase(stringParam) {
+  return stringParam.toLowerCase();
+}
 
-  for (let i = 0; i < words.length; i++) {
-    if (words[i].length > 5) {
-      capitalized.push(words[i].toUpperCase());
-    } else {
-      capitalized.push(words[i].toLowerCase());
-    }
-  }
+function isLongWord(word) {
+  return word.length > 5;
+}
 
-  return capitalized;
+function convertToConditionalUpperCase(words) {
+  return words.map(word => isLongWord(word) ? convertUpperCase(word) : convertLowerCase(word));
 }
 
 exports.convertToConditionalUpperCase = convertToConditionalUpperCase;