Add volume controls to media skill #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements volume controls to the media skill. It covers both increase the volume by one (not much, not really useful, if I'm being honest) and by user specified increments.
I think this is a good approach as it allows fine control by the user. However, there is an alternative implementation where we pick some number as the increment and just have a "turn it up/down" sentence that turns audio down, say, 5 times.
Important note: The non-English sentence files are computer translated. I have no idea if they're accurate or cover reasonable user expectations. It's just a best effort to keep the compiler happy and not have language regression for the media skill.