fix(security): disable Netty wire logging that dumps request/response bodies - #1289
fix(security): disable Netty wire logging that dumps request/response bodies#1289pallakartheekreddy wants to merge 1 commit into
Conversation
… bodies play.server.netty.log.wire was `true` in the content, search, taxonomy and assessment service confs and their Helm configmaps. Wire logging emits full request/response bytes -- headers (including x-authenticated-* identity/tokens) and bodies (user PII) -- to the logs, which then flow into shared log pipelines. Set log.wire = false everywhere (quick-win #3 in PLAN.md / the log-hygiene slice of the knowledge-platform design). The active provider is PekkoHttpServerProvider, so for the current deployment this is hardening / defense-in-depth (and fixes the misleading `true`), and it fully closes the leak on any environment that runs the Netty server backend. Config/values-only change; no code or API impact.
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (29)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Log-hygiene slice for knowledge-platform (PLAN.md quick-win #3).
play.server.netty { log.wire = true }was set in 4 service confs (content, search, taxonomy, assessment) and their 3 Helm configmaps.Why it matters
Netty wire logging emits the full request/response bytes — headers (including
x-authenticated-*identity headers / bearer tokens) and bodies (user PII) — into the application logs, which then flow into shared log pipelines. That's a credential/PII leak.The change
log.wire = falsein all 7 files. Config/values-only — no code or API impact.Note: the working tree had unrelated pre-existing
build/*deletions; this branch contains only the 7log.wirechanges.