Closed
Conversation
* Applied on startup failure aditionnaly to the backoff delay * Applied on bad exit status Default value is 0, which doesn't change the existing behavior. The goal is to impose a minimum delay between restarts to avoid overloading host with restarts.
|
👍 |
|
|
|
👍 |
1 similar comment
|
+1 |
|
@Supervisor is there any problem with this PR. There is also #487 where people ask for this. Is there something I can help with? |
|
PR #659 is based on your work, fclairamb and includes fixed for the tests. Wish me luck ;-) |
Author
|
Thank you very much !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to set a pause between the restarts of the program.
Typically, when you restart a database server, this can take few minutes and the backoff delay won't be enough. With a restart pause delay of something like 30 seconds, this becomes a lot less likely.
The alternative is to increase the number of start retries, but on system startup and/or when many programs fail at the same time (usually for the same reason), it creates an unnecessary workload on the host.
This changes the behaviors in two scenarios:
Default value is 0, which doesn't change the existing behavior.
It is mostly a proposal at this stage. We could also allow to change the backoff increment (which is hardcoded to 1 at the current stage) or only the backoff base delay.