[TASK] Drop popper-js & replace with HTML popover, fix & upgrade stylelint#1237
[TASK] Drop popper-js & replace with HTML popover, fix & upgrade stylelint#1237richardkrikler wants to merge 6 commits intoTYPO3-Documentation:mainfrom
Conversation
Also fixes all-documentations-menu desktop behavior. Hide below viewport width, as then mobile menu is used. Adjust phpunit.xml.dist: fixate UTC timezone for local dev usage.
richardkrikler
force-pushed
the
task/drop-popper
branch
from
20da2ef to
88b0ad3
Compare
…es/typo3-docs-theme (TYPO3-Documentation#1223)" This reverts commit ff81f59.
* Fix grunt stylelint path * Install missing @stylistic/stylelint-plugin package for stylelint v16 & update `.stylelintrc` * Add postcss-scss to allow parsing of `//` comments * Upgrade to stylelint v17 * npm run build
richardkrikler
changed the title
richardkrikler
changed the title
ineswillenbrock
left a comment
ineswillenbrock
left a comment
There was a problem hiding this comment.
Please add at least the role="tooltip" to All Documentation as mentioned.
And let's discuss the styling changes in the team as those enlage this PR.
| @@ -1,97 +1,101 @@ | |||
| { | |||
| "customSyntax": "postcss-scss", | |||
There was a problem hiding this comment.
why did you change this file?
There was a problem hiding this comment.
Please look at the commit message of 63bc152
It was necessary to be compatible with v16 of stylelint.
In v16 stylistic rules were removed and reloacted into another npm package → https://github.com/stylelint-stylistic/stylelint-stylistic#about-and-purpose
https://stylelint.io/migration-guide/to-16/
|
Note to everyone: after merging and releasing this PR we need to check api.typo3.org: popper is linked there and should get removed as well as the version in the CDN paths adopted. |
I understand the a11y problem & pushed a commit readding the deleted line. I cannot fully understand the other comments about SCSS code styling changes, as these were not done by me manually. |
ineswillenbrock
left a comment
ineswillenbrock
left a comment
There was a problem hiding this comment.
@richardkrikler regarding a11y: that's what I got reading this article: https://www.smashingmagazine.com/2026/03/getting-started-popover-api/
You mightbe right, if one refers to https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/tooltip_role
Might be actually rather role=menu if I read through the roles: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Roles/menu_role
Right now I'd like to keep the tooltip and open another issue to possible fix this object
2 participants
Also fixes all-documentations-menu desktop behavior.
Hide below viewport width, as then mobile menu is used.
Adjust phpunit.xml.dist: fixate UTC timezone for local dev usage.
Fix & update stylelint. (also solves #1203)