feat(mongodb): add full URI and Atlas/SRV support#2
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
|
This looks good for me, feel free to merge when you are ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the existing official MongoDB plugin with full connection URI and MongoDB Atlas support. It does not introduce a parallel plugin: the identity remains
mongodb/MongoDB, and the version remains0.1.0.Changes
mongodb://andmongodb+srv://connection URIs.host,port,username,password, anddatabaseconnections compatible.databaseas either a string or an array of selected database names.schemaas the active MongoDB database.connection_urisupport and themongodb/mongodb+srvschemes in the official manifest.Host compatibility
Full URI transport requires the host-side passthrough and secure per-connection storage introduced by TabularisDB/tabularis#495. Older Tabularis versions can continue using the legacy host/port fields, but cannot send a complete Atlas/SRV URI to an external plugin.
Scope
The diff is limited to:
README.mdmanifest.jsonsrc/main.rsRegistry changes and release publication are intentionally outside this PR.
Validation
cargo test: 20 passed, 0 failed.cargo build --release: passed.rustfmt --edition 2021 --check src/main.rs: passed.git diff --check: passed.test_connectionpassed;get_tablesreturned 16 collections with request-schema propagation; quoted collection browsing returned one row with 15 columns and expected pagination.The repository-wide
cargo fmt --checkstill reports formatting in unchanged upstreamsrc/bin/test.rs; the modified Rust file passes the formatter check above.