Fix PostgreSQL key metadata for readonly users - #543
Merged
debba merged 2 commits intoJul 28, 2026
Conversation
debba
approved these changes
Jul 28, 2026
debba
left a comment
Collaborator
There was a problem hiding this comment.
Thanks a lot for this contribution! The fix looks solid: the pg_catalog-based EXISTS expression is correlated on schema, table, and column, handles composite keys via unnest(conkey), and correctly skips dropped columns. I reproduced the original issue locally with a SELECT-only role — information_schema.table_constraints returns no rows for it while the new pg_constraint query correctly reports the primary key — so this genuinely fixes #96. Unit tests (102 passed) and the Postgres integration test both pass on the branch. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_catalogquery instead ofinformation_schema.table_constraints.Why
Issue #96 reports that readonly users can have access to
pg_constraintwhileinformation_schema.table_constraintsreturns no rows. That caused key metadata to be missed even when the required catalog data was visible.Validation
pnpm.cmd typecheckpnpm.cmd lintpnpm.cmd buildgit diff --checkpnpm.cmd exec gitnexus detect-changesreported low risk