fix(table-core): ensure isSubRowSelected returns false if no subRows are selectable #5790
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remleduff
force-pushed
the
feat-rowselection-with-no-selectable
branch
from
6af6819 to
c976103
Compare
remleduff
changed the title
remleduff
force-pushed
the
feat-rowselection-with-no-selectable
branch
from
c976103 to
e762532
Compare
remleduff
force-pushed
the
feat-rowselection-with-no-selectable
branch
from
e762532 to
2ae44a7
Compare
remleduff
changed the title
remleduff
changed the title
added 2 commits
November 5, 2024 12:55
remleduff
force-pushed
the
feat-rowselection-with-no-selectable
branch
from
6255ba8 to
220d8d3
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d87e9bc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Author
|
@KevinVandy Do I need to do anything for this? It seems like the automated fixes are correct, but when I click through to the workflow its status is "failed". |
Contributor
|
Any updates on this bugfix? |
|
Hi, is there anything that can be done to get this PR merged ? Would love to see it in the next release ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5173
Keep track whether we've seen any selectable rows and if not return false from isSubRowSelected.