Fix OSM→OSW handling for ext-only geometries and node reference export#47
Merged
Conversation
## Dev Board Ticket https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3477 https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3022 ## Changes **PR Title** Fix OSM→OSW handling for ext-only geometries and node reference export **PR Summary** This PR fixes several OSM→OSW regressions around `ext:*` tags and export classification. - Semantic feature recognition now uses canonical OSM tags only; `ext:*` tags are preserved as extensions instead of being treated as feature-defining tags. - Closed ext-only ways such as `ext:demolished:building=yes` now export correctly as polygons and no longer fall through to point geometry construction, which previously caused `KeyError: 'lon'`. - GeoJSON export now keeps topology endpoint points in `nodes.geojson`, ensuring edge `_u_id` and `_v_id` references remain OSW-compliant during roundtrip validation. - Added regression coverage for `bug_3477`, serializer-level node/point remapping, and the OSW compliance failure. - Bumped the package version to `0.3.3` and updated the changelog. ## Testing - Updated existing unit test cases - Added 2 new unit test cases
MashB
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3477
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3022
Changes
This PR fixes several OSM→OSW regressions around
ext:*tags and export classification.ext:*tags are preserved as extensions instead of being treated as feature-defining tags.ext:demolished:building=yesnow export correctly as polygons and no longer fall through to point geometry construction, which previously causedKeyError: 'lon'.nodes.geojson, ensuring edge_u_idand_v_idreferences remain OSW-compliant during roundtrip validation.bug_3477, serializer-level node/point remapping, and the OSW compliance failure.0.3.3and updated the changelog.Testing