Conversation
## Dev Board Ticket - https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/3607/ ## Changes - Added geometry mapping consistency validation for OSW datasets in `OSWValidation.validate()`: - `edges._u_id` must match edge start coordinate with referenced node coordinate. - `edges._v_id` must match edge end coordinate with referenced node coordinate. - `zones._w_id` referenced node coordinates must appear on zone polygon vertices. - Added standalone pure-Python geometry mapping validator module with reusable helpers for node indexing and edge/zone mapping checks. - Improved validation error reporting for geometry mapping mismatches with detailed, actionable context (dataset name, feature index/id, referenced node id, expected vs actual coordinates). - Bumped library version to `0.4.0` and updated changelog entries for the new geometry mapping feature set. - Added new geometry mapping fixtures and expanded unit test coverage across validator-level and end-to-end validation paths. ## Testing - Wrote **35 new unit test cases**: - 19 in `test_geometry_mapping_validator.py` - 10 in `test_osw_validation_extras.py` - 6 in `test_osw_validation.py` - Added dedicated unit tests for standalone geometry mapping validator covering valid cases, missing refs, unknown refs, coordinate mismatches, and integration aggregation. - Added end-to-end validation tests for `_u_id`, `_v_id`, and `_w_id` coordinate mismatch scenarios using fixture ZIP datasets. - Added mock-driven validation tests to ensure geometry mapping checks are exercised through `validate()` behavior and issue metadata output.
[0.4.0] Add geometry-to-node coordinate mapping validation
MashB
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
Changes
OSWValidation.validate():edges._u_idmust match edge start coordinate with referenced node coordinate.edges._v_idmust match edge end coordinate with referenced node coordinate.zones._w_idreferenced node coordinates must appear on zone polygon vertices.0.4.0and updated changelog entries for the new geometry mapping feature set.Testing
test_geometry_mapping_validator.pytest_osw_validation_extras.pytest_osw_validation.py_u_id,_v_id, and_w_idcoordinate mismatch scenarios using fixture ZIP datasets.validate()behavior and issue metadata output.