Update npm dependencies#51
Conversation
📝 WalkthroughWalkthroughUpgrades Nuxt and Vue versions, adds a Vite block in Nuxt config to restrict dev server hosts and pre-bundle listed dependencies, and updates the CI workflow to use Node.js 24. ChangesDevelopment Environment Setup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@nuxt.config.ts`:
- Around line 60-91: The optimizeDeps block is currently nested under
vite.server; move the optimizeDeps object out of the server section so it
becomes a sibling property directly under vite (i.e., change from
vite.server.optimizeDeps to vite.optimizeDeps) and keep the include array intact
(preserve the listed package entries like '`@osmcha/maplibre-adiff-viewer`',
'ajv', 'dayjs/plugin/relativeTime', etc.) so Vite can recognize the pre-bundling
configuration.
In `@package.json`:
- Line 28: package.json pins "nuxt": "^4.4.6" which requires Node >=22, but the
CI uses Node 20 causing installs to fail; fix by either updating the CI Node
runtime to a compatible major (22, 24, or 26+) in the workflow configuration or
change the "nuxt" dependency in package.json to a version compatible with Node
20 (downgrade "nuxt" to a 3.x/compatible release). Ensure the chosen approach
updates the CI workflow's node-version entry or the "nuxt" version string so
they match and then run CI locally (or npm ci) to verify installation succeeds.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0021313d-fe6e-4dd1-b102-91f21471b434
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
nuxt.config.tspackage.json
6994412 to
db6cf35
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 15-18: The workflow uses mutable tags actions/checkout@v4 and
actions/setup-node@v4 which violate the unpinned-uses policy; update both
occurrences to the corresponding immutable commit SHAs (replace
actions/checkout@v4 and actions/setup-node@v4 with their full commit SHA pins)
so the workflow references a specific commit for each action, and verify the SHA
values are the latest recommended SHAs from the official action repositories
before committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 89d22712-5d27-45bc-a75e-57546cacd6b6
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.github/workflows/ci.ymlnuxt.config.tspackage.json
|
Merging—discussed with/approved by @jeffmaki in yesterday's call. |
This is a dependency update that resolves some outstanding security notices. I updated the Nuxt config to account for a couple new features of the dev server:
Changes
Dependencies Updated
^4.0.0→^4.4.6^3.4.19→^3.5.34Nuxt Configuration Enhanced
Added
viteconfiguration tonuxt.config.ts:allowedHoststoworkspaces.localto explicitly allow requests from the local development domain.optimizeDeps.includeto pre-bundle key dependencies, reducing full page reloads during development. Included modules:@osmcha/*,@sindresorhus/slugify, Vue devtools packages,@zip.js/zip.js,ajv/ajv-formats,bootstrap-vue-nextcomponents/composables,dayjsplugins,maplibre-gl,papaparse,vue-qrcode, andvue3-toastify.CI Workflow