Skip to content

Fix missed call site from project group refactor#52

Merged
cyrossignol merged 1 commit into
masterfrom
fix-project-groups
May 19, 2026
Merged

Fix missed call site from project group refactor#52
cyrossignol merged 1 commit into
masterfrom
fix-project-groups

Conversation

@cyrossignol
Copy link
Copy Markdown
Collaborator

@cyrossignol cyrossignol commented May 19, 2026

This fixes a missed call of getMyProjectGroups() in #44 following rebase of #50 which changed the behavior of the method.

Summary

This PR fixes a missed update in the TDEI workspace export page's data loading logic that was introduced during the project group refactor from PR #50 and issue #44.

Changes

pages/workspace/[id]/export/tdei.vue

Updated the Promise.all call that fetches initial data to properly handle the API response structure:

  • Modified the getMyProjectGroups() call to include explicit pagination parameters: getMyProjectGroups(1, '', 10000)
  • Updated the destructuring pattern to extract the items property from the response object: { items: myProjectGroups } instead of receiving the list directly

This aligns with the API contract where getMyProjectGroups() returns an object with structure { items: TdeiProjectGroup[], total?: number } rather than directly returning an array. The fix ensures that eligibleProjectGroups is computed correctly from the proper array of project groups, maintaining the role-based export permission checks and default project-group selection logic.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 937e0450-63a5-4138-9efa-4416493ee904

📥 Commits

Reviewing files that changed from the base of the PR and between 91fc79e and bf070d4.

📒 Files selected for processing (1)
  • pages/workspace/[id]/export/tdei.vue

📝 Walkthrough

Walkthrough

The TDEI workspace export page updates its initial data loading to work with paginated API responses. The getMyProjectGroups call now includes explicit pagination parameters, and project groups are extracted from the items property of the returned response object rather than used directly.

Changes

TDEI Export Project Groups API Update

Layer / File(s) Summary
Project groups initialization with pagination
pages/workspace/[id]/export/tdei.vue
Promise.all destructuring calls getMyProjectGroups(1, '', 10000) with pagination parameters and extracts project groups from the items property instead of receiving the list directly, affecting eligibleProjectGroups computation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • susrisha
  • jeffmaki

Poem

🐰 Pages once asked for groups in full,
Now pagination makes the call pull,
.items extracted from response's might,
Export flows now structured right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main change: fixing a missed call site that resulted from a project group refactor, which aligns with the PR's objective of addressing a call to getMyProjectGroups() that wasn't updated after method behavior changed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cyrossignol cyrossignol requested a review from jeffmaki May 19, 2026 20:35
@cyrossignol cyrossignol merged commit a48e720 into master May 19, 2026
1 of 2 checks passed
@cyrossignol cyrossignol deleted the fix-project-groups branch May 19, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants