Fix missed call site from project group refactor#52
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TDEI workspace export page updates its initial data loading to work with paginated API responses. The ChangesTDEI Export Project Groups API Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This fixes a missed call of
getMyProjectGroups()in #44 following rebase of #50 which changed the behavior of the method.Summary
This PR fixes a missed update in the TDEI workspace export page's data loading logic that was introduced during the project group refactor from PR
#50and issue#44.Changes
pages/workspace/[id]/export/tdei.vue
Updated the
Promise.allcall that fetches initial data to properly handle the API response structure:getMyProjectGroups()call to include explicit pagination parameters:getMyProjectGroups(1, '', 10000)itemsproperty from the response object:{ items: myProjectGroups }instead of receiving the list directlyThis aligns with the API contract where
getMyProjectGroups()returns an object with structure{ items: TdeiProjectGroup[], total?: number }rather than directly returning an array. The fix ensures thateligibleProjectGroupsis computed correctly from the proper array of project groups, maintaining the role-based export permission checks and default project-group selection logic.