[FIX] 포커스 스키마 업데이트 반영 및 모달 완료 계획 시간 수정#259
Merged
Merged
Conversation
- 완료 모달에 전달되는 계획 시간에서 연장 시간을 제외했습니다 - Focus/사이드바는 타이머 서클 라벨(연장 포함 유지)과 완료 모달(계획만) 값을 분리했습니다
- 실제 응답은 여전히 BaseResponse로 감싸져 있는데 이전 재생성에서 래퍼 없는 타입으로 잘못 바뀌어 있던 것을 실제 동작 기준으로 복원했습니다
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Walkthrough완료 모달의 계획 시간이 연장 시간을 제외하도록 변경되었습니다. 홈·오늘·사이드바 타이머와 집중 세션에서 기본 계획 시간을 별도로 계산·전달하며, 집중 할 일 쿼리의 Changes기본 계획 시간 표시
집중 세션 상태 연결
집중 할 일 쿼리 파싱
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jjangminii
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/timo-web/app/`[locale]/(main)/(with-time-sidebar)/home/_containers/HomeTodoContainer.tsx:
- Around line 100-102: In the tests covering the completion modal and the
HomeTodoContainer timer flow, add a regression test using React Testing Library
render and user-focused queries with both plannedSeconds and extendedSeconds
populated; assert that the modal displays only the planned duration and does not
include the extended time.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: dc7b4031-82ce-48b8-a00e-9c41b86008cc
⛔ Files ignored due to path filters (3)
apps/timo-web/api/generated/endpoints/focus/focus.tsis excluded by!**/generated/**apps/timo-web/api/generated/endpoints/focus/focus.zod.tsis excluded by!**/generated/**apps/timo-web/api/generated/models/index.tsis excluded by!**/generated/**
📒 Files selected for processing (6)
apps/timo-web/app/[locale]/(main)/(with-time-sidebar)/home/_containers/HomeTodoContainer.tsxapps/timo-web/app/[locale]/(main)/(with-time-sidebar)/today/_containers/TodayTodoListContainer.tsxapps/timo-web/app/[locale]/(main)/focus/_containers/FocusSessionContainer.tsxapps/timo-web/app/[locale]/(main)/focus/_hooks/use-focus-session.tsapps/timo-web/app/[locale]/(main)/focus/_queries/use-focus-todo-query.tsapps/timo-web/components/layout/sidebar/time/TimerPanel.tsx
Comment on lines
100
to
102
| const plannedMinutes = activeTimer | ||
| ? convertDurationToMinutes( | ||
| activeTimer.plannedSeconds + activeTimer.extendedSeconds, | ||
| ) | ||
| ? convertDurationToMinutes(activeTimer.plannedSeconds) | ||
| : 0; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win
연장 시간을 제외하는 회귀 테스트를 추가해 주세요.
plannedSeconds와 extendedSeconds가 모두 있는 경우 완료 모달에는 전자만 표시되는지 검증하면, 이번 계약이 다시 합산 방식으로 되돌아가는 회귀를 막을 수 있습니다. React Testing Library의 render와 사용자 중심 쿼리 방식을 참고하면 됩니다. (testing-library.com)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@apps/timo-web/app/`[locale]/(main)/(with-time-sidebar)/home/_containers/HomeTodoContainer.tsx
around lines 100 - 102, In the tests covering the completion modal and the
HomeTodoContainer timer flow, add a regression test using React Testing Library
render and user-focused queries with both plannedSeconds and extendedSeconds
populated; assert that the modal displays only the planned duration and does not
include the extended time.
Timo Performance ReportBundle Size — timo-web
Lighthouse — timo-web
Image Optimization — timo-web
측정 커밋: |
kimminna
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE 🔗
close #258
What is this PR? 🔍
To Reviewers
Screenshot 📷
Test Checklist ✔