Conversation
Guryss
reviewed
Feb 8, 2026
Member
Guryss
left a comment
Guryss
left a comment
There was a problem hiding this comment.
확인했습니다 👍
혹시 테스트 함수명은 한글로 정의하는 부분은 어떨까요??
Comment on lines
+11
to
+13
| public struct Keyword: Equatable, Identifiable, Hashable { | ||
| public let id: Int | ||
| public let name: String |
Member
There was a problem hiding this comment.
해당 Keyword 구조체는 Keyword 모듈에서 정의하는 편이 좋으니 추후 합치면 좋겠네요
+) id는 KeywordID 같은 Value Object로 감쌀 필요가 없을까요?!
Collaborator
Author
There was a problem hiding this comment.
Keyword ID는 이미 Keyword 내부에 있기도 하고, 한 번 서버에서 받아온 값을 매핑하면 그 뒤에 편집이 없기 때문에 괜찮을 것 같습니다! 매핑하면 휴먼 에러를 줄일 수 있는데, 이 경우 줄일 휴먼 에러 자체가 없을 것 같아서요!
Keyword 구조체는 여기저기서 쓰이니 Keyword 모듈보다 BaseDomain에 두는게 어떨까요?
Comment on lines
+11
to
+14
| public struct Rating: Equatable { | ||
| public let value: Double | ||
|
|
||
| // MARK: - Policy |
Member
There was a problem hiding this comment.
해당 구조체도 BaseDomain에 넣어도 좋겠네요
이 Rating에 대한 write는 NovelReview에서만 진행하고, 이 외에서의 모듈에서는 read만 진행하니 사용해도 괜찮겠군요!
Collaborator
Author
There was a problem hiding this comment.
테스트 함수명은 Setting Domain 작성 시에 함께 수정해두었습니다
나머지는 메인 풀 받은 다음 반영해둘게요 !!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Issue
closed #20
💭 Summary