Add the option to make the application run on startup for all users#74
Add the option to make the application run on startup for all users#74anaszgh wants to merge 1 commit intoTeamwork:masterfrom
Conversation
anaszgh
commented
Dec 10, 2017
anaszgh
commented
- Target Platform: Windows
- Unable to make the application run on startup for all users
- Could it break any existing functionality for users? Nope
adam-lynch
left a comment
adam-lynch
left a comment
There was a problem hiding this comment.
Hey, thanks for this! I've just reviewed it. You should update the README too by the way.
I can't test it right now but I will later.
|
|
||
|
|
||
| # appName - {String} | ||
| # onlyMe - (Optional) {Boolean} |
There was a problem hiding this comment.
A comment for mac is missing
There was a problem hiding this comment.
Please, use a name that is more representative of what's the purpose of the parameter. We usually talk about a user-wide or a system-wide installation (something like "systemWideInstall").
| @@ -12,13 +12,14 @@ module.exports = class AutoLaunch | |||
| # to add Login Item | |||
| # :name - {String} | |||
| # :path - (Optional) {String} | |||
There was a problem hiding this comment.
You should add a new comment for the new option
| isHiddenOnLaunch: if isHidden? then isHidden else false | ||
| mac: mac ? {} | ||
| mac: mac ? {}, | ||
| onlyMe:onlyMe?true |
There was a problem hiding this comment.
Can you add some spaces here please?
There was a problem hiding this comment.
Same for a few other areas actually
|
As stated under #47, maybe we should regroup additional parameters under an array of options so the constructor's parameter list doesn't get longer than needed. |
|
Is it possible to offer the same functionality for macOS and Linux? Yes/No, document the state please. I think I saw something under Chromium/Chrome that could allow us to also do it for Linux. |
Oxalin
changed the title
3 participants
