Add PPTExporter with PPTX export support for PAGX documents by OnionsYu · Pull Request #3361 · Tencent/libpag

OnionsYu · 2026-04-03T08:02:58Z

新增 PPT 导出功能，支持将 PAGX 文档导出为 PPTX 格式。

主要变更：

新增 PPTExporter，支持形状、文本、图片填充、渐变、描边、阴影、蒙版等元素导出为 PPTX
提取 ExporterUtils 公共工具模块，供 SVG 和 PPT 导出器共用
重构 SVGExporter 和 SVGTextLayout 复用 ExporterUtils 中的共享方法
在 CLI CommandExport 中集成 PPT 导出命令
新增 PPT 导出测试用例

… PPTExporter.

…rter.

…ile mode instead of stretch mode.

…ect ratio instead of tile mode.

…correct x-y order.

…tch when tileModeX or tileModeY is Repeat or Mirror.

…rnate contours.

…mage is smaller than the shape.

…d JPEG metadata.

…mage pattern and shadow code.

codecov-commenter · 2026-04-03T08:13:48Z

Codecov Report

❌ Patch coverage is 88.69180% with 306 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.18%. Comparing base (ed723d4) to head (3ef19a8).

Files with missing lines	Patch %	Lines
src/pagx/ppt/PPTExporter.cpp	85.29%	83 Missing and 42 partials ⚠️
src/pagx/utils/ExporterUtils.cpp	74.62%	62 Missing and 39 partials ⚠️
src/pagx/xml/XMLBuilder.h	77.65%	23 Missing and 17 partials ⚠️
src/cli/CommandExport.cpp	71.73%	7 Missing and 6 partials ⚠️
src/pagx/ppt/PPTContourUtils.cpp	91.94%	2 Missing and 10 partials ⚠️
src/pagx/ppt/PPTWriterContext.h	88.37%	3 Missing and 2 partials ⚠️
src/pagx/ppt/PPTBoilerplate.cpp	95.23%	0 Missing and 4 partials ⚠️
src/pagx/ppt/PPTGeomEmitter.cpp	96.61%	2 Missing and 2 partials ⚠️
src/pagx/svg/SVGExporter.cpp	88.23%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
+ Coverage   78.22%   80.18%   +1.96%     
==========================================
  Files         529      541      +12     
  Lines       40527    45295    +4768     
  Branches    12234    12767     +533     
==========================================
+ Hits        31701    36321    +4620     
- Misses       6349     6400      +51     
- Partials     2477     2574      +97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ents and shadows.

…nding direction.

… methods and cache image type flags.

…rt_ppt2

…ter.

…and Keynote renderer compatibility.

…ridge-contours.

# Conflicts: # src/pagx/PAGXExporter.cpp resolved by main version

… the removed size member.

… sites to descriptive method names.

…ity.

…rt_ppt2 # Conflicts: # src/pagx/PAGXExporter.cpp resolved by origin/main(远端) version

…writeRawLine and writeComment methods.

…n and improve readability.

…id test resource.

…or handling.

…sistent rendering across apps.

…ture constant, and extract tiled pattern render helper.

shlzxjp

Code Review 第二轮：之前的26条评论中绝大多数已确认修复（包括 const_cast、静态常量命名、Xform初始化、UTF-8字符数、lambda消除、幻灯片等比缩放、zipWrite返回值检查等），修复质量很好。本轮新发现 12 个问题（1 Critical、3 Major、8 Minor），详见行级评论。

shlzxjp

Code Review 第三轮：新发现 10 个问题（1 Critical、4 Major、5 Minor），详见行级评论。

shlzxjp · 2026-04-14T11:30:10Z

+  ok = ok && AddZipString(zf, "ppt/slides/slide1.xml", slide);
+  ok = ok && AddZipString(zf, "ppt/slides/_rels/slide1.xml.rels", GenerateSlideRels(context));
+  ok = ok && AddZipString(zf, "ppt/slideMasters/slideMaster1.xml", GenerateSlideMaster());
+  ok = ok &&


[Critical] ToFile 中16个 AddZipString 调用和 AddZipEntry 循环的返回值全部被丢弃。任何一步写入失败后仍继续写入后续条目，最终只靠 zipClose 判断成败，但此时已产生部分写入的损坏文件。建议用 bool ok = true; ok = ok && AddZipString(...); 链式检查，首次失败即 zipClose 并返回 false。

shlzxjp · 2026-04-14T11:30:10Z

+          .closeElementSelfClosing();
+      out.closeElement();  // a:path
+      out.closeElement();  // a:gradFill
+      break;


[Major] RadialGradient 导出硬编码 fillToRect l/t/r/b=50000，渐变中心始终在形状正中。但 RadialGradient 节点有 matrix、startPoint、endPoint 等属性控制渐变位置，全部被忽略。如果 PAGX 文档中径向渐变中心偏移，导出结果将不正确。

shlzxjp · 2026-04-14T11:30:10Z

+    }
+    if (hasItalic) {
+      out.addRequiredAttribute("i", "1");
+    }


[Major] writeNativeText 只处理 SolidColor 填充，遇到 LinearGradient、RadialGradient 或 ImagePattern 时直接跳过，文本将以默认黑色显示且无任何警告。OOXML 的 a:rPr 支持 a:gradFill，建议至少对渐变填充做基本支持，或添加 fallback 提取渐变首色作为纯色近似。

shlzxjp · 2026-04-14T11:30:10Z

+  out.openElement("a:ln").closeElementStart();
+  out.openElement("a:noFill").closeElementSelfClosing();
+  out.closeElement();
+  writeEffects(out, filters);


[Major] writeEffects 在 p:spPr 内调用，阴影效果应用于整个文本框形状而非文本本身。OOXML 中文本阴影应通过 a:rPr 内的效果属性应用，否则阴影会出现在文本框边界而非文字轮廓上，视觉效果不正确。

shlzxjp · 2026-04-14T11:30:10Z

+  void writePicture(XMLBuilder& out, const std::string& relId, int64_t offX, int64_t offY,
+                    int64_t extCX, int64_t extCY);
+
+  // Write non-tiling ImagePattern fill as a separate p:pic element.


[Minor] DecomposeScale 实现了关键的矩阵分解逻辑（被 decomposeXform 和 writeTextAsPath 使用），但作为文件级 static 函数无法被单元测试覆盖。建议移入 ExporterUtils 使其可测试。

shlzxjp · 2026-04-14T11:30:10Z

+  float maxY = std::numeric_limits<float>::lowest();
+  for (const auto& contour : allContours) {
+    ExpandBounds(minX, minY, maxX, maxY, contour.start);
+    for (const auto& seg : contour.segs) {


[Minor] writeTextAsPath 的 bounds 计算只遍历轮廓端点（start + seg endpoints），对于 cubic bezier 段，曲线实际范围可能超出端点围成的区域。字形路径段密度高，实际偏差很小，但在极端情况下可能导致裁剪。建议添加注释说明此为端点近似。

shlzxjp · 2026-04-14T11:30:10Z

+    }
+  }
+}
+


[Minor] 内层轮廓归属查找用 break 选择第一个（按数组顺序）包含它的 depth=0 轮廓。如果存在多个不相交的外层轮廓，且因端点近似误差导致 PointInsideContour 误判，可能将内层轮廓归错组。概率低但逻辑上存在，建议添加注释说明此限制。

OnionsYu added 13 commits April 2, 2026 10:28

Add ExporterUtils with shared helper functions for PAGX exporters.

bdc4670

Refactor SVGTextLayout to reuse ComputeGlyphPaths from ExporterUtils.

7de4194

Refactor SVGExporter to reuse shared helpers from ExporterUtils.

721feaf

Add PPTExporter with PPTX export support for PAGX documents.

3321b2c

Fix XML attribute escaping and strip quotes from font family names in…

a29b78c

… PPTExporter.

Remove unused fillRule parameter from writeCustomGeom in PPTExporter.

218dc4e

Fix zero-dimension path bounds handling for stroked shapes in PPTExpo…

83f37f5

…rter.

Add mask layer rasterization support to PPTExporter.

4519189

Add image pattern fill cropping and JPEG dimension parsing support.

1e21b4c

Add preset dash pattern matching for stroke dashes in PPTExporter.

ad7a653

Fix image pattern fill stretching distortion in PPT export by using t…

5e83842

…ile mode instead of stretch mode.

Fix image pattern fill by using srcRect plus fillRect to preserve asp…

4171d66

…ect ratio instead of tile mode.

Fix linear gradient angle calculation by swapping atan2 arguments to …

49d618a

…correct x-y order.

OnionsYu requested review from Hparty, domchen, kevingpqi123 and shlzxjp as code owners April 3, 2026 08:03

OnionsYu added 7 commits April 3, 2026 16:06

Fix ImagePattern tiling in PPT export to use a:tile instead of a:stre…

6651d32

…tch when tileModeX or tileModeY is Repeat or Mirror.

Emulate even-odd fill rule in PPT export by reversing winding of alte…

013def6

…rnate contours.

Export non-tiling ImagePattern as a separate p:pic element when the i…

25996cc

…mage is smaller than the shape.

Fix image pattern tiling scale by applying DPI correction from PNG an…

72cc868

…d JPEG metadata.

Refactor PPTExporter by extracting shared helpers and deduplicating i…

ae96374

…mage pattern and shadow code.

Reformat PrintUsage alignment in CommandExport.

2ddf405

Add PPT export test that converts SVG files to PPTX via PAGX roundtrip.

cdaf2a3

OnionsYu force-pushed the feature/onionsyu_export_ppt2 branch from 1bc505f to cdaf2a3 Compare April 3, 2026 08:07

OnionsYu added 4 commits April 3, 2026 16:26

Add comprehensive PPT export unit tests for shapes and text and gradi…

0adbf25

…ents and shadows.

Add unit tests for PAGX exporter utility functions.

8529dec

Fix even-odd fill emulation by using signed area to detect contour wi…

697adbb

…nding direction.

Reformat byte array alignment in PAGXUtilsTest.

deb8fb3

shlzxjp reviewed Apr 9, 2026

View reviewed changes

Comment thread src/pagx/ppt/PPTExporter.cpp Outdated

shlzxjp reviewed Apr 9, 2026

View reviewed changes

Comment thread test/src/PAGXPPTTest.cpp Outdated

OnionsYu added 11 commits April 9, 2026 17:18

Refactor PPTExporter to extract shared WriteXfrm and WriteContourGeom…

9e538d2

… methods and cache image type flags.

Merge remote-tracking branch 'origin/main' into feature/onionsyu_expo…

fccc6af

…rt_ppt2

Address PR review feedback for PPTExporter.

7f804a8

Make bridge-contours opt-in via new bridgeContours option in PPTExpor…

65a0082

…ter.

Compact PPTWriter initializer list to a single line.

9b58802

Split multi-contour glyphs and paths into separate shapes for WeChat …

fb83b36

…and Keynote renderer compatibility.

Change bridgeContours default to true and flip CLI flag to --ppt-no-b…

02f6619

…ridge-contours.

Split PPTExporter.cpp into focused modules for better maintainability.

9983dea

Merge branch 'main' into feature/onionsyu_export_ppt2

74ff077

# Conflicts: # src/pagx/PAGXExporter.cpp resolved by main version

Adapt PPTExporter and PPT tests to TextBox width/height API replacing…

2804b59

… the removed size member.

Auto apply layout before exporting PAG document to PPT file.

664c2dd

OnionsYu force-pushed the feature/onionsyu_export_ppt2 branch from 56f6b20 to 664c2dd Compare April 13, 2026 02:54

OnionsYu added 5 commits April 13, 2026 12:57

Unify XMLBuilder API by removing short aliases and migrating all call…

53d0bdd

… sites to descriptive method names.

Reformat chained XMLBuilder calls in PPT exporter for better readabil…

df82baa

…ity.

Merge remote-tracking branch 'origin/main' into feature/onionsyu_expo…

230cada

…rt_ppt2 # Conflicts: # src/pagx/PAGXExporter.cpp resolved by origin/main(远端) version

Move XMLBuilder from PAGXExporter.cpp to shared XMLBuilder.h and add …

4efd934

…writeRawLine and writeComment methods.

Refactor PPT exporter by extracting helpers to reduce code duplicatio…

4a3415f

…n and improve readability.

OnionsYu force-pushed the feature/onionsyu_export_ppt2 branch from df0a742 to 4a3415f Compare April 13, 2026 06:33

OnionsYu added 5 commits April 13, 2026 15:00

Remove Export_PagxToPptx_WithDocErrors test case that relied on inval…

773718a

…id test resource.

Refactor PPT exporter to extract shared helpers and add zip write err…

6692cf7

…or handling.

Add bakeTiledPattern option to rasterize tiled image patterns for con…

e630e9d

…sistent rendering across apps.

Refactor PPT exporter to hoist loop invariants, deduplicate PNG signa…

73fec28

…ture constant, and extract tiled pattern render helper.

Fix code formatting in PPTExporter and ExporterUtils.

e957a27

shlzxjp reviewed Apr 13, 2026

View reviewed changes

Address PR review round 2 with 12 fixes across PPT exporter modules.

3ef19a8

shlzxjp reviewed Apr 14, 2026

View reviewed changes

Comment thread src/cli/CommandExport.cpp

Comment thread src/pagx/ppt/PPTExporter.cpp Outdated

shlzxjp reviewed Apr 14, 2026

View reviewed changes

Improve PPT exporter code style and add clarifying comments.

a5cde13

Conversation

OnionsYu commented Apr 3, 2026

Uh oh!

codecov-commenter commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

shlzxjp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shlzxjp left a comment

Choose a reason for hiding this comment

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

shlzxjp Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Apr 3, 2026 •

edited

Loading