https://github.com/Tencent/tquic/issues/153 - #452
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #452 +/- ##
===========================================
- Coverage 95.39% 95.28% -0.11%
===========================================
Files 50 50
Lines 34238 34273 +35
===========================================
- Hits 32660 32656 -4
- Misses 1578 1617 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces mutual authentication configurations for both client and server TLS setups while slightly improving error handling paths.
- Adds a new function for mutual authentication client configuration.
- Adds a new function for mutual authentication server configuration.
- Slightly refactors variable typing and error handling in existing functions.
| ) -> Result<Self> { | ||
| if cert_file.is_empty() || key_file.is_empty() { | ||
| return Err(Error::TlsFail(format!( | ||
| "cert_file({:?}) key_file({:?})", |
There was a problem hiding this comment.
Consider improving the error message here to clearly state that both certificate and key files are required, e.g., 'Certificate file and key file must be provided, but received cert_file: {:?}, key_file: {:?}'.
| "cert_file({:?}) key_file({:?})", | |
| "Certificate file and key file must be provided, but received cert_file: {:?}, key_file: {:?}", |
| Ok(tls_config) | ||
| } | ||
|
|
||
| pub fn new_mutual_authentication_client_config( |
There was a problem hiding this comment.
Add a doc comment for 'new_mutual_authentication_client_config' to explain its purpose and usage, aligning its documentation with that of 'new_server_config' for clarity.
No description provided.