Skip to content

fix: hoist github/google SSO defaults to module scope#1065

Open
lhojun wants to merge 1 commit into
Termix-SSH:mainfrom
lhojun:fix/sso-provider-defaults-scope
Open

fix: hoist github/google SSO defaults to module scope#1065
lhojun wants to merge 1 commit into
Termix-SSH:mainfrom
lhojun:fix/sso-provider-defaults-scope

Conversation

@lhojun

@lhojun lhojun commented Jul 17, 2026

Copy link
Copy Markdown

Overview

Fixes a "githubDefaults/googleDefaults is not defined" error when saving a GitHub or Google SSO provider.

  • Fixed: adding a GitHub or Google SSO provider throwing a ReferenceError on save

Changes Made

buildConfig() in the top-level dialog component reads githubDefaults / googleDefaults, but those were declared locally inside OIDCConfigFields, so they weren't in scope there. Selecting provider type "GitHub" (throws githubDefaults is not defined) or "Google" (throws googleDefaults is not defined) and hitting Save always errored before any request went out.

Moved both constants to module scope so buildConfig() and OIDCConfigFields share them.

Related Issues

None

Screenshots / Demos

None

Checklist

  • Code follows project style guidelines
  • Supports mobile and desktop UI/app (if applicable)
  • I have read Contributing.md
  • This is not a translation request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant