fix: hoist github/google SSO defaults to module scope#1065
Open
lhojun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a "githubDefaults/googleDefaults is not defined" error when saving a GitHub or Google SSO provider.
Changes Made
buildConfig()in the top-level dialog component readsgithubDefaults/googleDefaults, but those were declared locally insideOIDCConfigFields, so they weren't in scope there. Selecting provider type "GitHub" (throwsgithubDefaults is not defined) or "Google" (throwsgoogleDefaults is not defined) and hitting Save always errored before any request went out.Moved both constants to module scope so
buildConfig()andOIDCConfigFieldsshare them.Related Issues
None
Screenshots / Demos
None
Checklist