feature(headless): Add ParticleSystemManagerDummy for headless mode#2247
Open
bobtista wants to merge 2 commits intoTheSuperHackers:mainfrom
Open
feature(headless): Add ParticleSystemManagerDummy for headless mode#2247bobtista wants to merge 2 commits intoTheSuperHackers:mainfrom
bobtista wants to merge 2 commits intoTheSuperHackers:mainfrom
Conversation
Greptile Overview
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/GameClient/ParticleSys.h | Added ParticleSystemManagerDummy class with no-op implementations of all required virtual methods for headless mode |
| Generals/Code/GameEngine/Source/Common/GameEngine.cpp | Uses ParticleSystemManagerDummy when m_headless is true, consistent with existing AudioManagerDummy and RadarDummy patterns |
| GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp | Uses ParticleSystemManagerDummy when m_headless is true, consistent with existing AudioManagerDummy and RadarDummy patterns |
Sequence Diagram
sequenceDiagram
participant GE as GameEngine
participant GD as TheGlobalData
participant Factory as createParticleSystemManager()
participant Dummy as ParticleSystemManagerDummy
participant PSM as TheParticleSystemManager
GE->>GD: Check m_headless flag
alt m_headless == true
GE->>Dummy: NEW ParticleSystemManagerDummy
Dummy-->>PSM: Initialize as singleton
Note over Dummy: All methods are no-ops:<br/>getOnScreenParticleCount() returns 0<br/>doParticles() does nothing<br/>queueParticleRender() does nothing<br/>crc/xfer/loadPostProcess() skip save data
else m_headless == false
GE->>Factory: createParticleSystemManager()
Factory-->>PSM: Initialize full implementation
Note over PSM: Normal particle system<br/>with rendering and updates
end
GE->>PSM: initSubsystem(TheParticleSystemManager)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related
Split from #2139 per @xezon's suggestion to review each dummy class separately.