feat: add QuizQuestion and TriviaManager classes for Java trivia game by EJ-Edwards · Pull Request #40 · Together-Java/TJ-Plays

EJ-Edwards · 2026-03-09T17:23:19Z

please review my code and let me know if I am missing any errors. Note be nice since this is my actual first commit I would like guidance on this.

christolis · 2026-03-09T17:29:29Z

@EJ-Edwards Hello and congratulations on opening your first pull request in this repository.

Have you tested that this code works in a development environment? If so, it would be nice and convenient to have a preview of how it works in the form of screenshots or GIFs, embedded in the pull request description. 👍

EJ-Edwards · 2026-03-09T21:08:34Z

ok so I tested it on my end it works for me. Please let me know if they are any errors and I will fix it.

EJ-Edwards · 2026-03-09T21:10:40Z

also if I am making a mistake or it messes up sorry like I said this is my first time actually contributing.

christolis · 2026-03-09T21:47:07Z

EJ-Edwards left a comment (Together-Java/TJ-Plays#40) also if I am making a mistake or it messes up sorry like I said this is my first time actually contributing.

Sure. I have not looked at the code yet. How can a member of the server play the Java quiz game from the Discord bot? Is there a command you have to trigger in order to activate the game? Some sort of interaction with the bot from the Discord client? These details need to be specified in the pull request description to make it easier for the people reviewing your code changes. ~Chris

- Added JavaQuizCommand: Discord slash command that fetches a random Java trivia question via ChatGPT and presents it with answer buttons - Added TriviaManager: service that prompts ChatGPT for quiz questions and parses the JSON response - Added QuizQuestion: data model for trivia questions - Added javaquiz.java: standalone entry point for local testing - Added runQuiz Gradle task for convenience testing - Registered /javaquiz command in Bot.java How to play: A server member types /javaquiz in Discord. The bot displays a random Java trivia question with 4 answer buttons. The user clicks their answer and the bot reveals whether it was correct. Everything should work please let me know if I am missing anything Best -EJ

EJ-Edwards · 2026-03-09T21:59:49Z

Ok Chris thank you and I just want to say thank you for taking your time and basically guiding me through the contribution process.

christolis · 2026-03-09T22:18:29Z

Every time I select an answer, I get the following stacktrace:

00:15:52.365 [JDA MainWS-ReadThread] ERROR net.dv8tion.jda.api.JDA - One of the EventListeners had an uncaught exception
java.lang.IllegalArgumentException: Cannot have empty row!
        at net.dv8tion.jda.internal.utils.Checks.check(Checks.java:62) ~[JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.api.interactions.components.ActionRow.of(ActionRow.java:126) ~[JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.api.utils.messages.MessageRequest.setActionRow(MessageRequest.java:329) ~[JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at com.togetherjava.tjplays.listeners.commands.JavaQuizCommand.onButtonInteraction(JavaQuizCommand.java:84) ~[main/:?]
        at net.dv8tion.jda.api.hooks.ListenerAdapter.onEvent(ListenerAdapter.java:447) ~[JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.api.hooks.InterfacedEventManager.handle(InterfacedEventManager.java:96) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.hooks.EventManagerProxy.handleInternally(EventManagerProxy.java:88) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.hooks.EventManagerProxy.handle(EventManagerProxy.java:70) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.JDAImpl.handleEvent(JDAImpl.java:173) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.handle.InteractionCreateHandler.handleAction(InteractionCreateHandler.java:134) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.handle.InteractionCreateHandler.handleInternally(InteractionCreateHandler.java:86) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.handle.SocketHandler.handle(SocketHandler.java:39) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.requests.WebSocketClient.onDispatch(WebSocketClient.java:1007) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.requests.WebSocketClient.onEvent(WebSocketClient.java:893) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.requests.WebSocketClient.handleEvent(WebSocketClient.java:871) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at net.dv8tion.jda.internal.requests.WebSocketClient.onBinaryMessage(WebSocketClient.java:1046) [JDA-5.0.0-beta.21.jar:5.0.0-beta.21]
        at com.neovisionaries.ws.client.ListenerManager.callOnBinaryMessage(ListenerManager.java:385) [nv-websocket-client-2.14.jar:?]
        at com.neovisionaries.ws.client.ReadingThread.callOnBinaryMessage(ReadingThread.java:276) [nv-websocket-client-2.14.jar:?]
        at com.neovisionaries.ws.client.ReadingThread.handleBinaryFrame(ReadingThread.java:996) [nv-websocket-client-2.14.jar:?]
        at com.neovisionaries.ws.client.ReadingThread.handleFrame(ReadingThread.java:755) [nv-websocket-client-2.14.jar:?]
        at com.neovisionaries.ws.client.ReadingThread.main(ReadingThread.java:108) [nv-websocket-client-2.14.jar:?]
        at com.neovisionaries.ws.client.ReadingThread.runMain(ReadingThread.java:64) [nv-websocket-client-2.14.jar:?]
        at com.neovisionaries.ws.client.WebSocketThread.run(WebSocketThread.java:45) [nv-websocket-client-2.14.jar:?]

Has this feature been tested thoroughly?

EJ-Edwards · 2026-03-09T22:35:05Z

Hello Chris and I actually thought this would work thank you for letting me know also is there a bot token where I can test the bot in a discord server or no?

tj-wazei

Overall a pretty small and simple PR, great work. Just some small comments.

Could you provide some screenshots of how this looks in action? Possible a screen recording if that isn't too much to ask?

Thanks

app/src/main/java/com/togetherjava/tjplays/games/game2048/javaquiz.java

app/src/main/java/com/togetherjava/tjplays/games/game2048/QuizQuestion.java

app/src/main/java/com/togetherjava/tjplays/games/game2048/TriviaManager.java

app/src/main/java/com/togetherjava/tjplays/listeners/commands/JavaQuizCommand.java

app/build.gradle

.gitignore

tj-wazei · 2026-03-09T22:53:31Z

Hello Chris and I actually thought this would work thank you for letting me know also is there a bot token where I can test the bot in a discord server or no?

You'll need to create your own Discord server and Discord bot token via the website. We unfortunantely, cannot give you ours. https://discord.com/developers/applications

…Manager for single question retrieval chore: Remove unused javaquiz main class and add gradle.properties for JDK configuration fix: Improve button interaction handling in JavaQuizCommand I addressed all the review feedback and pushed the changes. I wasn't able to provide screenshots because the bot hangs on startup — it appears the shared OpenAI API key from the pinned message may be expired or invalid. The bot connects to Discord fine (I confirmed it joins the server and receives slash commands), but the ChatGPT API call in ChatGptService times out during initialization. Could someone verify the key is still active?

EJ-Edwards · 2026-03-09T23:41:44Z

Ok so that should be everything please let me know that this works.

gradle.properties

christolis

Additionally while testing the game on my local Discord server It turns out that I can call the command multiple times without answering the previous question and I can effectively spam the chat by doing so, even if I am muted or have a time out in my account.

Kindly check that out.

Screenshot

christolis · 2026-03-10T14:14:50Z

app/src/main/java/com/togetherjava/tjplays/trivia/QuizQuestion.java

+
+import java.util.List;
+
+public record QuizQuestion(


Since this is public-facing, it should have a JavaDoc explaining what it is, where it's used in and where it could be used by future contributors.

christolis · 2026-03-10T14:17:40Z

app/src/main/java/com/togetherjava/tjplays/games/game2048/QuizQuestion.java

+public record QuizQuestion(
+        @JsonProperty("question") String question,
+        @JsonProperty("choices") List<String> choices,
+        @JsonProperty("correct") int correctIndex


NIT: It took me a little bit to understand what correctIndex represents. Something like correctAnswerIndex would help.

christolis · 2026-03-10T14:21:18Z

app/src/main/java/com/togetherjava/tjplays/games/game2048/QuizQuestion.java

@@ -0,0 +1,27 @@
+package com.togetherjava.tjplays.games.game2048;


Why is this class part of the games.game2048 package?

christolis · 2026-03-10T14:22:04Z

app/src/main/java/com/togetherjava/tjplays/games/game2048/TriviaManager.java

@@ -0,0 +1,30 @@
+package com.togetherjava.tjplays.games.game2048;


Why is this class part of the games.game2048 package?

christolis · 2026-03-10T14:22:40Z

app/src/main/java/com/togetherjava/tjplays/games/game2048/TriviaManager.java

+import java.util.Optional;
+
+public class TriviaManager {
+    private final ChatGptService gpt;


Please properly name this variable to chatGptService.

christolis · 2026-03-10T14:32:38Z

app/src/main/java/com/togetherjava/tjplays/listeners/commands/JavaQuizCommand.java

+
+    public JavaQuizCommand(String openAiKey) {
+        super(Commands.slash(COMMAND_NAME, "Get a random Java trivia question"));
+        this.triviaManager = new TriviaManager(openAiKey);


Just like in this code review comment, I believe that we should let callers pass down an instance of TriviaManager.

christolis · 2026-03-10T14:33:47Z

app/src/main/java/com/togetherjava/tjplays/listeners/commands/JavaQuizCommand.java

+            return;
+        }
+
+        QuizQuestion q = question.get();


Let's use proper variable names instead of a single letter for readability. q could be quizQuestion and the current question can be quizQuestionOptional.

christolis · 2026-03-10T14:39:50Z

app/src/main/java/com/togetherjava/tjplays/listeners/commands/JavaQuizCommand.java

+        StringBuilder sb = new StringBuilder();
+        sb.append("**Java Quiz**\n\n");
+        sb.append(q.getQuestion()).append("\n\n");
+        for (int i = 0; i < choices.size(); i++) {
+            sb.append("`").append(i + 1).append(")` ").append(choices.get(i)).append("\n");
+        }


Let's not use sb as a variable name. This whole highlighted code block is also unreadable.

A lot of things could be changed here, and the removal of StringBuilder is a good place to start from.

Firstly, we should use String.format(...) as it's more readable and does not have .append() being repeated a lot.

Secondly, sending a MessageEmbed would allow for the code to be cleaner but also for the UI/UX to be significantly more structured.

app/src/main/java/com/togetherjava/tjplays/listeners/commands/JavaQuizCommand.java

…nd update JavaQuizCommand accordingly

…onality. Created a new folder for the package let me know if this works.

feat: add QuizQuestion and TriviaManager classes for Java trivia game

492d648

EJ-Edwards requested review from a team as code owners March 9, 2026 17:23

christolis linked an issue Mar 9, 2026 that may be closed by this pull request

Add Java quiz game #13

Open

feat: add javaquiz class to implement trivia game functionality

06d3d1c

tj-wazei requested changes Mar 9, 2026

View reviewed changes

Zabuzard requested changes Mar 10, 2026

View reviewed changes

gradle.properties Outdated Show resolved Hide resolved

accidental commit

6e09485

EJ-Edwards requested review from Zabuzard and tj-wazei March 10, 2026 12:49

christolis requested changes Mar 10, 2026

View reviewed changes

refactor: Rename correctIndex to correctAnswerIndex in QuizQuestion a…

ab3d603

…nd update JavaQuizCommand accordingly

EJ-Edwards requested a review from christolis March 10, 2026 16:29

feat: Implement TriviaManager and QuizQuestion for Java trivia functi…

607ec27

…onality. Created a new folder for the package let me know if this works.

		@@ -0,0 +1,27 @@
		package com.togetherjava.tjplays.games.game2048;

		@@ -0,0 +1,30 @@
		package com.togetherjava.tjplays.games.game2048;

Conversation

EJ-Edwards commented Mar 9, 2026

Uh oh!

christolis commented Mar 9, 2026

Uh oh!

EJ-Edwards commented Mar 9, 2026

Uh oh!

EJ-Edwards commented Mar 9, 2026

Uh oh!

christolis commented Mar 9, 2026 via email

Uh oh!

EJ-Edwards commented Mar 9, 2026

Uh oh!

christolis commented Mar 9, 2026

Uh oh!

EJ-Edwards commented Mar 9, 2026

Uh oh!

tj-wazei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tj-wazei commented Mar 9, 2026

Uh oh!

EJ-Edwards commented Mar 9, 2026

Uh oh!

Uh oh!

christolis left a comment

Choose a reason for hiding this comment

Screenshot

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

christolis Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

christolis Mar 10, 2026 •

edited

Loading