Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades dependencies and adds a "copy yesterday" feature to the diary application. The upgrade includes JavaScript build tools (rollup, vite) and Calcit ecosystem packages, while the new feature allows users to reuse their previous day's diary entry.
Changes:
- Upgraded @calcit/procs (0.10.4 → 0.10.9), rollup (4.54.0 → 4.55.1), and vite (7.3.0 → 7.3.1)
- Added "Like last day" button that copies yesterday's diary data when food and pains fields are empty
- Extensive documentation updates in llms/ directory covering Respo event handling and Calcit CLI workflows
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updated JavaScript dependencies with new versions and added @rollup/rollup-openbsd-x64 platform support |
| package.json | Updated @calcit/procs and vite dependencies to match yarn.lock |
| deps.cirru | Updated calcit-version and pinned some Respo packages to specific versions |
| compact.cirru | Added copy-yesterday function, UI button with conditional display, and dispatch handler; added :about metadata |
| llms/Respo.md | Removed Chinese troubleshooting section; added component listener and event handling documentation |
| llms/Calcit.md | Extensive documentation improvements including CLI workflows, type annotations, and best practices |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {} | ||
| :year $ dec year | ||
| :month 12 | ||
| :day 31 |
There was a problem hiding this comment.
Hardcoded 31 days for December of the previous year will fail for leap year February transitions. When going from January 1st to December 31st of the previous year, if that year's February was a leap year, the logic should calculate days using get-days-by. Consider using app.util/get-days-by (dec year) 12 instead of hardcoding 31.
| :day 31 | |
| :day $ app.util/get-days-by year 12 |
| {} $ :class-name css/row-middle | ||
| when | ||
| and (blank? (:food diary)) (blank? (:pains diary)) | ||
| button $ {} (:class-name css/button) (:inner-text "|Like last day") |
There was a problem hiding this comment.
The button text 'Like last day' is ambiguous. Consider renaming to 'Copy from yesterday' or 'Reuse yesterday's entry' to make the action clearer to users.
| button $ {} (:class-name css/button) (:inner-text "|Like last day") | |
| button $ {} (:class-name css/button) (:inner-text "|Copy from yesterday") |
1 participant
No description provided.