fix: generate forgot-password link in hash routing format and update …

[sreenandpk]

…assertions

Summary by CodeRabbit

• Bug Fixes
  • Updated password-reset links in emails to use the frontend’s hash-based reset route, improving compatibility with the password reset experience.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 34958190-fbf5-49dd-b920-132c14f3eaf0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• ✅ Review completed - (🔄 Check again to review again)

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/connection

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

tests/test_password_reset.py (1)

353-353: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Assert the token-bearing URL, not only its prefix.

Stub or capture the generated plain token and assert the exact /#/reset-password/<token> URL appears in the email HTML. The current assertion would pass for an empty or malformed token.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_password_reset.py` at line 353, Update the password-reset email
test around the token generation and email HTML assertion to stub or capture the
generated plain token, then assert the exact /#/reset-password/<token> URL
appears in call_kwargs["html"] instead of checking only the URL prefix.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/test_password_reset.py`:
- Line 353: Update the password-reset email test around the token generation and
email HTML assertion to stub or capture the generated plain token, then assert
the exact /#/reset-password/<token> URL appears in call_kwargs["html"] instead
of checking only the URL prefix.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b6fd964-d22c-4132-bbf6-6e9732a84245

📥 Commits

Reviewing files that changed from the base of the PR and between 3f352bf and b0d7353.

📒 Files selected for processing (2)

• src/ai_trading_discipline_copilot/routers/auth.py
• tests/test_password_reset.py