Improve lexer performance using struct-array#64
Merged
Conversation
spoenemann
approved these changes
Apr 27, 2026
Member
spoenemann
left a comment
There was a problem hiding this comment.
Great!
Do we need to update https://www.typefox.io/blog/fastbelt-introduction/ again 😁?
9ef74b2 to
f3ae4b2
Compare
Member
Author
We could, though it's only a roughly ~4% performance increase in total. |
f3ae4b2 to
a70ca5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performs some minor and a major performance optimizations:
TokenSliceuses theTokenstruct directly instead of using a pointer. This improves lexing performance by ~40%slices.IndexFuncto a custom loop. Does not influence performance - it seems like the Go compiler was able to inline the function call. However, this still makes everything easier to read.