Fix inline_string_encode and inline_string_decode#576
Fix inline_string_encode and inline_string_decode#576arch1t3cht merged 5 commits intoTypesettingTools:masterfrom
inline_string_encode and inline_string_decode#576Conversation
inline_string_encode and inline_string_encodeinline_string_encode and inline_string_decode
arch1t3cht
left a comment
There was a problem hiding this comment.
Thanks! LGTM except one small nit and the failing Windows CI, which looks like a missing #include <string> in string_codec.h.
90e76c2 to
ec15e39
Compare
|
I addressed the nit and added the missing include, let's see if the CI passes now. Before moving
Maybe include-what-you-use could help clean up includes in the codebase? |
|
Oops, I accidentally amended the wrong commit, let me fix that |
Previously it depended on whether char was signed or unsigned
ec15e39 to
34d404d
Compare
|
Thanks!
Yes, definitely. There's a bunch of static analysis tooling that I'd like to set up eventually but haven't gotten to yet. It might also (or additionally) be an option to just also disable PCHs on the Windows and Mac CI. This wasn't done originally in #303 because the Windows CI already takes a very long time, but I since realized that the vast majority of time is spent compiling dependencies rather than Aegisub itself. So disabling PCHs for Aegisub would not have that much of an impact on the CI runtime. |
charis signedstring_codec.cppto libaegisub so that it can be tested