Fix/speed up varro 1#502
Conversation
tcouch
left a comment
tcouch
left a comment
There was a problem hiding this comment.
I'm not sure where the problem is occurring, but when running locally I'm not seeing any links show up under any of the works in the ordered material section:
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self.antiquarian = Antiquarian.objects.get(pk=pk) | ||
| return self.antiquarian | ||
| def get_response(self): | ||
| return HttpResponseRedirect(self.get_success_url()) |
| self.antiquarian = Antiquarian.objects.get(pk=pk) | ||
| return self.antiquarian | ||
| def get_response(self): | ||
| return HttpResponseRedirect(self.get_success_url()) |
There was a problem hiding this comment.
You horror! Once it actually works it's no faster at all. Still, I found a small optimization that's nothing to do with all this work. To get any further I'll need Django 5. Will it actually be faster? I hope so.
There was a problem hiding this comment.
I do think this work will really help get the original_text (and reference) prefetching working. But... it's a big job to make any of this stuff cover the work that all the templates are doing, especially getting display texts.
There was a problem hiding this comment.
Yeah, that's why I thought lazy loading might be a better option: create a separate view for work lists and have htmx fetch the content when the user expands the accordion.
Thanks! That sorts it. Co-authored-by: Tom Couch <t.couch@ucl.ac.uk>
tim-band
force-pushed
the
fix/speed-up-varro-1
branch
from
be37472 to
5a9eec6
Compare
3 participants
This improves the loading of the Varro Antiquarian page from 63 seconds to about 36.
Updated from Django 3 to Django 4. This required a little bit of cleaning up some nastiness.
More is needed; it turns out I can't prefetch original_texts because Django 3 cannot cope with prefetching through a
GenericRelation.However, Django 5 can! Sadly I can't upgrade to Django 5 without upgrading Postgres.
So how about we do this, Django 4. Then if we need more speed we can upgrade to Postgres 14 and have a go at upgrading to Django 5. Then I can see if prefetching original_texts helps (probably will!).