-
Notifications
You must be signed in to change notification settings - Fork 75
ci: Replace depcheck with knip #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,634
−3,719
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * @type {import('knip').KnipConfig} | ||
| */ | ||
| const config = { | ||
| /** | ||
| * We only need dependency checking at the moment, | ||
| * so all checks except for dependencies are turned off. | ||
| */ | ||
| rules: { | ||
| files: "off", | ||
| duplicates: "off", | ||
| classMembers: "off", | ||
| unlisted: "off", | ||
| binaries: "off", | ||
| unresolved: "off", | ||
| catalog: "off", | ||
| exports: "off", | ||
| types: "off", | ||
| enumMembers: "off", | ||
| /** | ||
| * We also ignore peer dependencies because @ui5/project | ||
| * defines an optional peer dependency to @ui5/builder | ||
| * which is needed and not an issue in our point of view. | ||
| */ | ||
| optionalPeerDependencies: "off" | ||
| }, | ||
|
|
||
| ignoreDependencies: [ | ||
| /** | ||
| * Used via nyc ava --node-arguments="--experimental-loader=@istanbuljs/esm-loader-hook" | ||
| * which is not detected by knip as a usage of this package | ||
| */ | ||
| "@istanbuljs/esm-loader-hook" | ||
| ], | ||
|
|
||
| workspaces: { | ||
| ".": { | ||
| ignoreDependencies: [ | ||
| /** | ||
| * Invoked manually via "npx husky" to install git hooks | ||
| */ | ||
| "husky" | ||
| ] | ||
| }, | ||
| "packages/cli": { | ||
| ignoreDependencies: [ | ||
| /** | ||
| * The package.json files of all @ui5/* packages are dynamically required for the "version" command | ||
| * (See packages/cli/lib/cli/commands/versions.js) | ||
| * Only @ui5/fs is not used anywhere else in the CLI package, so we need to ignore it here | ||
| */ | ||
| "@ui5/fs" | ||
| ], | ||
| entry: [ | ||
| /** | ||
| * Commands are dynamically loaded via readdir (see packages/cli/lib/cli/cli.js) | ||
| */ | ||
| "lib/cli/commands/*.js" | ||
| ] | ||
| }, | ||
| "packages/server": { | ||
| /** | ||
| * We ignore these dependencies here because these are dynamic imports | ||
| * and knip is unable to detect that these are being used | ||
| * (See packages/server/lib/middleware/MiddlewareManager.js) | ||
| */ | ||
| ignoreDependencies: [ | ||
| "compression", | ||
| "cors" | ||
| ] | ||
| }, | ||
| "packages/*": { | ||
| }, | ||
| "internal/documentation": { | ||
| ignoreDependencies: [ | ||
| /** | ||
| * Used in internal/documentation/postcss.config.js but can't be detected | ||
| * as the plugin is dynamically applied based on NODE_ENV. | ||
| */ | ||
| "cssnano", | ||
| /** | ||
| * Used as jsdoc template in package.json script, which is not detected | ||
| */ | ||
| "docdash" | ||
| ] | ||
| }, | ||
| "internal/*": { | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| module.exports = config; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.