fix(ui5-avatar-group): use getSlottedNodes for transitive slot support #13049
+18
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When items are passed through a transitive slot (e.g., when AvatarGroup is used inside another component that forwards content via a slot), this.items returns the slot element itself instead of the actual avatars. Use getSlottedNodes to properly resolve transitive slotting and retrieve the actual avatar items regardless of nesting depth.
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13049--ui5-webcomponents.netlify.app |
dobrinyonkov
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_slottedItemsgetter that usesgetSlottedNodesto resolve nested slot elementsthis.itemswiththis._slottedItemsWhen AvatarGroup is used inside another component that forwards content via a
<slot>element,this.itemsreturns the slot element itself instead of the actual avatar items. This fix ensures proper item resolution regardless of slot nesting depth.Test plan