feat(monitor-v2): add SETTLE_ONLY_DISPUTED option to settlement bot#4941
Merged
Reinis-FRP merged 4 commits intomasterfrom Mar 30, 2026
Merged
feat(monitor-v2): add SETTLE_ONLY_DISPUTED option to settlement bot#4941Reinis-FRP merged 4 commits intomasterfrom
Reinis-FRP merged 4 commits intomasterfrom
Conversation
When enabled, the bot only settles requests that were disputed and resolved via the DVM, skipping undisputed proposals that expired naturally. For OOv2/ManagedOOv2, uses on-chain getState() to check dispute status. For SkinnyOO, filters using already-queried DisputePrice events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove the SkinnyOO filtering — the option now only applies to OptimisticOracleV2 and ManagedOptimisticOracleV2. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reinis-FRP
approved these changes
Mar 30, 2026
Contributor
Reinis-FRP
left a comment
Reinis-FRP
left a comment
There was a problem hiding this comment.
This should work as short-term solution. If this was staying as longer-term code we could though refactor this to start from DisputePrice events entirely (instead of ProposePrice) as that avoids additional state check and would allow extending lookback period due to less events to begin with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SETTLE_ONLY_DISPUTEDenv var (defaultfalse) to the OO settlement bottrue, only settles requests that were disputed and resolved via the DVM, skipping undisputed expired proposalsgetState()to check dispute status per request — no extra event queries neededTest plan
settleOnlyDisputedskips undisputed expired proposalssettleOnlyDisputedsettles disputed+DVM-resolved proposals🤖 Generated with Claude Code