Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new indel category "non-hmer Indel + hmer Indel <=12" to the variant reporting system, combining non-homopolymer indels with short homopolymer indels (length ≤12).
Changes:
- Added filtering logic for the new combined indel category in the report utilities
- Extended the category list in the variant report notebook to include the new category
- Updated the ugbio_utils subproject commit reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ugvc/reports/report_utils.py | Implements filtering logic for the new combined indel category |
| ugvc/reports/createVarReport.ipynb | Adds the new category to the reporting categories list |
| ugbio_utils | Updates subproject commit reference |
Comments suppressed due to low confidence (1)
ugvc/reports/report_utils.py:533
- This line exceeds 120 characters and contains complex nested boolean logic that is difficult to read. Consider breaking this into multiple lines or extracting the conditions into named variables for better readability.
result = data[((data["indel"]) & (data["hmer_length"] == 0) & (data["indel_length"] > 0)) | ((data["indel"]) & (data["hmer_length"] > 0) & (data["hmer_length"] <= 12))]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
doron-st
reviewed
Feb 23, 2026
Collaborator
doron-st
left a comment
There was a problem hiding this comment.
suggested simplification
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Primarily reporting/test-schema changes and a small import refactor; risk is limited to downstream consumers expecting the old CSV column layout or category list.
Overview
Extends concordance/report outputs to include an
aucpr(area under PR curve) metric in the generatedexpected.out.stats.csvtest fixture, shifting the CSV schema accordingly.Adds a new reporting category,
non-hmer Indel + hmer Indel <=12, and implements its filter logic inreport_utils.__filter_by_category, enabling combined indel performance summaries increateVarReport.ipynb.Refactors
run_no_gt_report.pyto import and callannotate_concordancedirectly fromugbio_comparison.vcf_comparison_utils(instead of viacomparison_utils).Written by Cursor Bugbot for commit e30240d. This will update automatically on new commits. Configure here.