Skip to content

Update GitHub workflows #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 1 commit into from
Jan 25, 2026
+100 −19
Merged

Update GitHub workflows #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 97 additions & 16 deletions .github/workflows/build-ultraplot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,34 @@ jobs:

- name: Test Ultraplot
run: |
status=0
filter_nodeids() {
local filtered=""
for nodeid in ${TEST_NODEIDS}; do
local path="${nodeid%%::*}"
if [ -f "$path" ]; then
filtered="${filtered} ${nodeid}"
fi
done
echo "${filtered}"
}
if [ "${TEST_MODE}" = "selected" ] && [ -n "${TEST_NODEIDS}" ]; then
pytest -n auto --cov=ultraplot --cov-branch --cov-report term-missing --cov-report=xml ${TEST_NODEIDS}
FILTERED_NODEIDS="$(filter_nodeids)"
if [ -z "${FILTERED_NODEIDS}" ]; then
echo "No valid nodeids found; running full suite."
pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$?
else
pytest -q --tb=short --disable-warnings -n 0 ${FILTERED_NODEIDS} || status=$?
if [ "$status" -eq 4 ] || [ "$status" -eq 5 ]; then
echo "No tests collected from selected nodeids; running full suite."
status=0
pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$?
fi
fi
else
pytest -n auto --cov=ultraplot --cov-branch --cov-report term-missing --cov-report=xml ultraplot
pytest -q --tb=short --disable-warnings -n 0 ultraplot || status=$?
fi

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
slug: Ultraplot/ultraplot
exit "$status"

compare-baseline:
name: Compare baseline Python ${{ inputs.python-version }} with MPL ${{ inputs.matplotlib-version }}
Expand Down Expand Up @@ -98,9 +115,9 @@ jobs:
with:
path: ./ultraplot/tests/baseline # The directory to cache
# Key is based on OS, Python/Matplotlib versions, and the base commit SHA
key: ${{ runner.os }}-baseline-base-${{ github.event.pull_request.base.sha }}-${{ inputs.python-version }}-${{ inputs.matplotlib-version }}
key: ${{ runner.os }}-baseline-base-v2-${{ github.event.pull_request.base.sha }}-${{ inputs.python-version }}-${{ inputs.matplotlib-version }}
restore-keys: |
${{ runner.os }}-baseline-base-${{ github.event.pull_request.base.sha }}-${{ inputs.python-version }}-${{ inputs.matplotlib-version }}-
${{ runner.os }}-baseline-base-v2-${{ github.event.pull_request.base.sha }}-${{ inputs.python-version }}-${{ inputs.matplotlib-version }}-

# Conditional Baseline Generation (Only runs on cache miss)
- name: Generate baseline from main
Expand All @@ -120,12 +137,41 @@ jobs:
# Generate the baseline images and hash library
python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')"
if [ "${TEST_MODE}" = "selected" ] && [ -n "${TEST_NODEIDS}" ]; then
pytest -W ignore \
status=0
filter_nodeids() {
local filtered=""
for nodeid in ${TEST_NODEIDS}; do
local path="${nodeid%%::*}"
if [ -f "$path" ]; then
filtered="${filtered} ${nodeid}"
fi
done
echo "${filtered}"
}
FILTERED_NODEIDS="$(filter_nodeids)"
if [ -z "${FILTERED_NODEIDS}" ]; then
echo "No valid nodeids found; running full suite."
pytest -q --tb=short --disable-warnings -W ignore \
--mpl-generate-path=./ultraplot/tests/baseline/ \
--mpl-default-style="./ultraplot.yml" \
ultraplot/tests || status=$?
else
pytest -q --tb=short --disable-warnings -W ignore \
--mpl-generate-path=./ultraplot/tests/baseline/ \
--mpl-default-style="./ultraplot.yml" \
${TEST_NODEIDS}
${FILTERED_NODEIDS} || status=$?
if [ "$status" -eq 4 ] || [ "$status" -eq 5 ]; then
echo "No tests collected from selected nodeids on base; running full suite."
status=0
pytest -q --tb=short --disable-warnings -W ignore \
--mpl-generate-path=./ultraplot/tests/baseline/ \
--mpl-default-style="./ultraplot.yml" \
ultraplot/tests || status=$?
fi
fi
exit "$status"
else
pytest -W ignore \
pytest -q --tb=short --disable-warnings -W ignore \
--mpl-generate-path=./ultraplot/tests/baseline/ \
--mpl-default-style="./ultraplot.yml" \
ultraplot/tests
Expand All @@ -145,15 +191,50 @@ jobs:
mkdir -p results
python -c "import ultraplot as plt; plt.config.Configurator()._save_yaml('ultraplot.yml')"
if [ "${TEST_MODE}" = "selected" ] && [ -n "${TEST_NODEIDS}" ]; then
pytest -W ignore \
status=0
filter_nodeids() {
local filtered=""
for nodeid in ${TEST_NODEIDS}; do
local path="${nodeid%%::*}"
if [ -f "$path" ]; then
filtered="${filtered} ${nodeid}"
fi
done
echo "${filtered}"
}
FILTERED_NODEIDS="$(filter_nodeids)"
if [ -z "${FILTERED_NODEIDS}" ]; then
echo "No valid nodeids found; running full suite."
pytest -q --tb=short --disable-warnings -W ignore \
--mpl \
--mpl-baseline-path=./ultraplot/tests/baseline \
--mpl-results-path=./results/ \
--mpl-generate-summary=html \
--mpl-default-style="./ultraplot.yml" \
ultraplot/tests || status=$?
else
pytest -q --tb=short --disable-warnings -W ignore \
--mpl \
--mpl-baseline-path=./ultraplot/tests/baseline \
--mpl-results-path=./results/ \
--mpl-generate-summary=html \
--mpl-default-style="./ultraplot.yml" \
${TEST_NODEIDS}
${FILTERED_NODEIDS} || status=$?
if [ "$status" -eq 4 ] || [ "$status" -eq 5 ]; then
echo "No tests collected from selected nodeids; running full suite."
status=0
pytest -q --tb=short --disable-warnings -W ignore \
--mpl \
--mpl-baseline-path=./ultraplot/tests/baseline \
--mpl-results-path=./results/ \
--mpl-generate-summary=html \
--mpl-default-style="./ultraplot.yml" \
ultraplot/tests || status=$?
fi
fi
exit "$status"
else
pytest -W ignore \
pytest -q --tb=short --disable-warnings -W ignore \
--mpl \
--mpl-baseline-path=./ultraplot/tests/baseline \
--mpl-results-path=./results/ \
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ jobs:
uses: actions/cache/restore@v4
with:
path: .ci/test-map.json
key: test-map-${{ github.event.pull_request.base.sha }}
key: test-map-v2-${{ github.event.pull_request.base.sha }}
restore-keys: |
test-map-
test-map-v2-

- name: Select impacted tests
id: select
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-map.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Generate test coverage map
run: |
mkdir -p .ci
pytest -n auto --cov=ultraplot --cov-branch --cov-context=test --cov-report= ultraplot
pytest -q --tb=short --disable-warnings -n 0 -p pytest_cov --cov=ultraplot --cov-branch --cov-context=test --cov-report= ultraplot
python tools/ci/build_test_map.py --coverage-file .coverage --output .ci/test-map.json --root .

- name: Cache test map
Expand Down