Skip to content

feat(registration): add member repository#52

Merged
WilliamTayNZ merged 6 commits into
mainfrom
feat/46-add-registration-repo
Jul 12, 2026
Merged

feat(registration): add member repository#52
WilliamTayNZ merged 6 commits into
mainfrom
feat/46-add-registration-repo

Conversation

@dasher1505

Copy link
Copy Markdown
Contributor

No description provided.

@WilliamTayNZ WilliamTayNZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! just a few things

Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated

@WilliamTayNZ WilliamTayNZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Dasher 🔥 almost ready to go, just a few tiny changes, see comments

Also, since createMembershipRegistration is an important function which actually creates the membership registration, it would be good to specify an explicit contract for what it returns:

type CreateMembershipRegistrationResult =
  | { ok: true }
  | { ok: false; error: { type: "duplicate" | "database" } };

The function's return type should wrap the result type in a Promise, since the function is asynchronous.

Well done

Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated
Comment thread src/repositories/memberRepository.ts Outdated

@WilliamTayNZ WilliamTayNZ left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

WilliamTayNZ
WilliamTayNZ previously approved these changes Jul 12, 2026
@WilliamTayNZ WilliamTayNZ merged commit 56643a7 into main Jul 12, 2026
1 check passed
@WilliamTayNZ WilliamTayNZ deleted the feat/46-add-registration-repo branch July 12, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants