feat(registration): add member repository#52
Merged
Conversation
WilliamTayNZ
requested changes
May 26, 2026
WilliamTayNZ
left a comment
Collaborator
There was a problem hiding this comment.
good work! just a few things
WilliamTayNZ
requested changes
Jun 6, 2026
WilliamTayNZ
left a comment
Collaborator
There was a problem hiding this comment.
Good work Dasher 🔥 almost ready to go, just a few tiny changes, see comments
Also, since createMembershipRegistration is an important function which actually creates the membership registration, it would be good to specify an explicit contract for what it returns:
type CreateMembershipRegistrationResult =
| { ok: true }
| { ok: false; error: { type: "duplicate" | "database" } };The function's return type should wrap the result type in a Promise, since the function is asynchronous.
Well done
WilliamTayNZ
previously approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.