Skip to content

Fix/past events UI#101

Merged
joengy merged 9 commits into
mainfrom
fix/past-events-ui
Jun 3, 2026
Merged

Fix/past events UI#101
joengy merged 9 commits into
mainfrom
fix/past-events-ui

Conversation

@becky-n

@becky-n becky-n commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixed UI changes for past events card to match figma and be more readable.

Checklist

  • My branch follows the naming convention (feature/, fix/, chore/, hotfix/)
  • My commit messages follow the conventional commits format
  • CI checks pass

Linked Issues

Closes #95 and #84

Copilot AI review requested due to automatic review settings June 2, 2026 14:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Events page “Past Events” UI to better match the Figma designs by improving mobile layout (horizontal scrolling) and refining the past event card visuals for readability.

Changes:

  • Switch past events listing to a horizontally scrollable, snap-aligned row on mobile while retaining the grid layout on larger screens.
  • Adjust past event card styling (corner radius, hover blur/opacity, and add a 25% black overlay) to improve text legibility and match Figma.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
web/src/app/events/_components/PastEventsSection.tsx Makes the past events list horizontally scrollable on mobile with snap behavior; preserves grid layout at sm+.
web/src/app/events/_components/PastEventCard.tsx Refines card styling (radius, hover image treatment, overlay, gradients, icon sizing) to improve readability and match design.
Comments suppressed due to low confidence (1)

web/src/app/events/_components/PastEventCard.tsx:92

  • This card still uses text-white/text-white/90 in several places, while other updated parts use the palette token text-ssa-white. Using the palette token throughout keeps the card consistent with the design system color (--color-ssa-white) and avoids mixing pure white with the off-white brand color.
      <div className="absolute inset-x-0 bottom-0 flex flex-col gap-3 p-6">
        <div className="flex items-center gap-2 text-white/90">
          <FaCalendarDays
            className="h-[1em] w-[1em] shrink-0"
            aria-hidden="true"
          />
          <time
            dateTime={date}
            className="font-averia text-base font-bold tracking-wide"
          >
            {formattedDate}
          </time>
        </div>
        <h3 className="font-averia text-3xl font-bold leading-tight text-white">
          {name}
        </h3>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 44 to +49
<Image
src={thumbnail}
alt={thumbnailAlt}
fill
sizes="(max-width: 640px) 100vw, (max-width: 1024px) 50vw, 33vw"
className="object-cover transition-all duration-500 group-hover:scale-105 group-hover:blur-[2px] group-hover:brightness-75"
className="object-cover transition-all duration-500 group-hover:scale-105 group-hover:blur-[6px] group-hover:brightness-65 group-hover:opacity-80"
Comment on lines +62 to +66
<div className="absolute left-5 top-5 flex items-center gap-2 text-ssa-white">
<FaLocationDot
className="h-[0.8em] w-[0.8em] shrink-0"
aria-hidden="true"
/>
Comment on lines 96 to 116
<li
key={tag}
className={`rounded-full px-4 py-1 font-averia text-base font-bold text-white ${TAG_COLOURS[tag]}`}
>
{tag}
</li>
))}
</ul>
)}
</div>

{/* Hover overlay: See Photos */}
<div className="pointer-events-none absolute inset-0 flex items-center justify-center opacity-0 transition-opacity duration-500 group-hover:opacity-100 group-focus-visible:opacity-100">
<span className="flex items-center gap-2.5 rounded-full bg-ssa-red px-8 py-3.5 font-averia text-xl font-bold text-white shadow-lg">
See Photos
<FaArrowRight className="h-6 w-6" aria-hidden="true" />
<FaArrowRight
className="h-[1em] w-[1em] shrink-0"
aria-hidden="true"
/>
</span>
</div>

@oorjagandhi oorjagandhi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for taking this on!

Just some small fixes:

  • pls make all text on the card text-ssa-white
  • decrease calender icon size OR increase date text size, so they are consistently sized
  • another change I forgot to flag initially - could you please decrease the border radius on the tags to make them more square:
Image

here is Figma so you can take the border radius

Thank you!

Copilot AI review requested due to automatic review settings June 2, 2026 15:09
@becky-n becky-n requested a review from oorjagandhi June 2, 2026 15:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@joengy joengy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the styling of the past events, just a heads-up, PR #75 (the sponsors page that Jotinder was working on) also retyles the same HighlightCard component, but differently it adds an explicit variant field to a HighlightCardBadge object instead of matching on the badge text (badge.toLowerCase().includes('non-member')).

I think its worth taking a look at how it's done because whichever PR gets merged second will have conflicts.

oorjagandhi
oorjagandhi previously approved these changes Jun 3, 2026

@oorjagandhi oorjagandhi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copilot AI review requested due to automatic review settings June 3, 2026 03:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

fill
sizes="(max-width: 640px) 100vw, (max-width: 1024px) 50vw, 33vw"
className="object-cover transition-all duration-500 group-hover:scale-105 group-hover:blur-[2px] group-hover:brightness-75"
className="object-cover transition-all duration-500 group-hover:scale-105 group-hover:blur-[6px] group-hover:brightness-65 group-hover:opacity-80"

@joengy joengy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joengy joengy merged commit 954d32b into main Jun 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EVENT-15 - Past Events UI cleanup

4 participants