Use * for keyword-only arguments in pytest fixtures#1989
Merged
adamtheturtle merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| @pytest.fixture | ||
| def cloud_reco_client( | ||
| *, |
There was a problem hiding this comment.
Missing * in fixture_vumark_target fixture signature
Low Severity
The PR intends to add * for keyword-only arguments to all fixtures with parameters, but fixture_vumark_target was missed. It still uses vumark_database as a positional argument while the other two fixtures with arguments (vws_client and cloud_reco_client) were updated with *. This creates an inconsistency in the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pytest fixture functions should use
*for keyword-only arguments when they have arguments. This change adds*to all affected fixtures.Made with Cursor
Note
Low Risk
Low risk: test-only change that only tightens fixture signatures to require keyword-only injection, with no production logic impact.
Overview
Updates
tests/conftest.pyfixtures to make their dependencies keyword-only by adding*tovws_clientandcloud_reco_clientparameters, aligning with pytest fixture style and preventing accidental positional usage.Written by Cursor Bugbot for commit b5c351f. This will update automatically on new commits. Configure here.