Skip to content

Use * for keyword-only arguments in pytest fixtures#1989

Merged
adamtheturtle merged 2 commits intomainfrom
pytest-fixture-keyword-only-args
Feb 23, 2026
Merged

Use * for keyword-only arguments in pytest fixtures#1989
adamtheturtle merged 2 commits intomainfrom
pytest-fixture-keyword-only-args

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 23, 2026

Pytest fixture functions should use * for keyword-only arguments when they have arguments. This change adds * to all affected fixtures.

Made with Cursor


Note

Low Risk
Low risk: test-only change that only tightens fixture signatures to require keyword-only injection, with no production logic impact.

Overview
Updates tests/conftest.py fixtures to make their dependencies keyword-only by adding * to vws_client and cloud_reco_client parameters, aligning with pytest fixture style and preventing accidental positional usage.

Written by Cursor Bugbot for commit b5c351f. This will update automatically on new commits. Configure here.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.


@pytest.fixture
def cloud_reco_client(
*,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing * in fixture_vumark_target fixture signature

Low Severity

The PR intends to add * for keyword-only arguments to all fixtures with parameters, but fixture_vumark_target was missed. It still uses vumark_database as a positional argument while the other two fixtures with arguments (vws_client and cloud_reco_client) were updated with *. This creates an inconsistency in the codebase.

Fix in Cursor Fix in Web

@adamtheturtle adamtheturtle merged commit fddeff3 into main Feb 23, 2026
16 checks passed
@adamtheturtle adamtheturtle deleted the pytest-fixture-keyword-only-args branch February 23, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant