Use * for keyword-only arguments in pytest fixtures#3014
Merged
adamtheturtle merged 3 commits intomainfrom Feb 23, 2026
Merged
Conversation
Image.open() was used without explicit close or context manager. When the source is a file stream (e.g. multipart upload), this can hold file handles until garbage collection. Prefer 'with Image.open(...) as img:' to ensure files are closed promptly. Fixes resource leak in: - image_matchers.py (StructuralSimilarityMatcher) - _query_validators/image_validators.py (validate_image_format, validate_image_dimensions, validate_image_is_image) - _services_validators/image_validators.py (validate_image_integrity, validate_image_format, validate_image_color_space, validate_image_is_image) - target.py (ImageTarget._post_processing_status) - target_raters.py (_get_brisque_target_tracking_rating) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest fixture functions should use
*for keyword-only arguments when they have arguments. This change adds*to all affected fixtures.Made with Cursor
Note
Low Risk
Test-only signature changes to make fixture dependencies keyword-only; low risk unless any fixtures are called directly as functions outside pytest injection.
Overview
Standardizes pytest fixtures to use keyword-only parameters by adding
*to fixture function signatures intests/conftest.py,tests/mock_vws/fixtures/prepared_requests.py, and the autouse fixture intests/mock_vws/test_flask_app_usage.py.This is a non-functional test harness change intended to prevent accidental positional argument usage in fixtures and align with the project’s fixture style.
Written by Cursor Bugbot for commit 41d4100. This will update automatically on new commits. Configure here.