fix: wait for Generate button to be enabled in Add Database dialog#1356
Merged
adamtheturtle merged 1 commit intomainfrom May 7, 2026
Merged
fix: wait for Generate button to be enabled in Add Database dialog#1356adamtheturtle merged 1 commit intomainfrom
adamtheturtle merged 1 commit intomainfrom
Conversation
The button is briefly disabled while the form revalidates after the VuMark radio is selected, so the immediate click was a silent no-op and the dialog never submitted. Cloud DB tests masked this because the license dropdown interaction provided enough delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_submit_add_database_dialog. The button is briefly disabled while the dialog revalidates after the VuMark radio is selected, so the previous immediate click was a silent no-op andstaleness_oftimed out — failing all VuMark tests on the scheduled CI runs. Cloud DB tests passed because the license-dropdown interaction provided enough delay.Test plan
test_create_vumark_database_librarypasses locallyNote
Low Risk
Low risk change confined to Selenium UI automation; it replaces an immediate click with an explicit clickability wait to avoid timing-related test failures.
Overview
Fixes flaky database creation automation by waiting for the Add Database dialog’s
Generatebutton to become clickable before clicking it._submit_add_database_dialognow usesWebDriverWait.until(element_to_be_clickable)(and drops the directdriver.find_elementusage), and call sites increate_cloud_databaseandcreate_vumark_databaseare updated to pass only thewaitobject.Reviewed by Cursor Bugbot for commit 8d4cf9d. Bugbot is set up for automated code reviews on this repo. Configure here.