Skip to content

fix: wait for Generate button to be enabled in Add Database dialog#1356

Merged
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/fix-ci
May 7, 2026
Merged

fix: wait for Generate button to be enabled in Add Database dialog#1356
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/fix-ci

Conversation

@adamtheturtle
Copy link
Copy Markdown
Member

@adamtheturtle adamtheturtle commented May 7, 2026

Summary

  • Wait for the Generate button to be clickable before clicking it in _submit_add_database_dialog. The button is briefly disabled while the dialog revalidates after the VuMark radio is selected, so the previous immediate click was a silent no-op and staleness_of timed out — failing all VuMark tests on the scheduled CI runs. Cloud DB tests passed because the license-dropdown interaction provided enough delay.

Test plan

  • test_create_vumark_database_library passes locally
  • Scheduled CI run goes green (cloud + license tests already passed; the fix shares the same submission path)

Note

Low Risk
Low risk change confined to Selenium UI automation; it replaces an immediate click with an explicit clickability wait to avoid timing-related test failures.

Overview
Fixes flaky database creation automation by waiting for the Add Database dialog’s Generate button to become clickable before clicking it.

_submit_add_database_dialog now uses WebDriverWait.until(element_to_be_clickable) (and drops the direct driver.find_element usage), and call sites in create_cloud_database and create_vumark_database are updated to pass only the wait object.

Reviewed by Cursor Bugbot for commit 8d4cf9d. Bugbot is set up for automated code reviews on this repo. Configure here.

The button is briefly disabled while the form revalidates after the
VuMark radio is selected, so the immediate click was a silent no-op
and the dialog never submitted. Cloud DB tests masked this because
the license dropdown interaction provided enough delay.
@adamtheturtle adamtheturtle enabled auto-merge (squash) May 7, 2026 09:09
@adamtheturtle adamtheturtle merged commit 61a1ac3 into main May 7, 2026
30 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/fix-ci branch May 7, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant