Parse Jest test results from system-out - #48
Merged
tgodzik merged 1 commit intoMay 20, 2026
Conversation
Member
|
Thanks for contributing! Could you run formatting on the PR? Otherwise looks good. |
harunaOseni
force-pushed
the
fix/jest-system-out-test-results-server
branch
from
May 19, 2026 18:56
bcfddbf to
7d14440
Compare
Author
|
Done, thanks. |
mnoah1
pushed a commit
to uber/vscode-bazel-bsp
that referenced
this pull request
May 25, 2026
## Problem Project and source-directory runs for TypeScript Jest targets were executing the broad Bazel target without narrowing to the selected test file. A run could therefore fail because of another file or suite in the same Bazel target, while the selected file or suite had passing tests. Test Explorer then only had the aggregate target failure to apply and could show unrelated discovered tests or suite containers as failed. ## Summary - Keep TypeScript-specific run behavior behind language tools. - Run TypeScript source-directory selections at source-file granularity. - Pass the selected TypeScript test file as a BSP test argument so Bazel/Jest narrows execution to that file. - Keep non-TypeScript source-directory behavior unchanged. - Let container/suite nodes inherit child statuses instead of forcing aggregate target failures onto them. - Filter TypeScript source discovery to actual Jest test file names. ## Related server change - Pairs with VirtusLab/bazel-bsp#48 so Jest child statuses can be reported when Bazel XML only contains an aggregate failed testcase and detailed Jest output is in `system-out`. ## Test plan - `yarn test-compile` - `yarn lint:single src/test-info/test-info.ts src/test/suite/test-info.test.ts` - Manual: packaged and installed the extension locally, then verified file, directory, and suite runs use file-scoped execution and preserve individual child statuses for mixed pass/fail results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some JavaScript/TypeScript test runners can produce Bazel XML with only an aggregate failed testcase while the detailed Jest results are present in
system-out. In that case BSP clients receive only the target-level failure and cannot mark individual Jest test cases accurately.Summary
system-outwhen the normal JUnit testcase data is incomplete.Test plan
bazel test //server/server/src/test/kotlin/org/jetbrains/bsp/bazel/server/bep:TestXmlParserTestsystem-outfor mixed pass/fail runs.