-
Notifications
You must be signed in to change notification settings - Fork 1
ci(build): Add automated dry run build when submitting a PR #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
WalkthroughA new GitHub Actions workflow file is added to configure continuous integration for pull requests targeting the devel branch. The workflow executes R environment setup, dependency installation, and Bioconductor build verification steps on ubuntu-latest. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/dry-run-build.yml (2)
2-4: Consider adding explicit permissions and a job timeout.Best practice for GitHub Actions is to declare required permissions explicitly and set a timeout to prevent hanging builds, especially for long-running build/check operations.
Apply this diff to add a permissions block and timeout:
name: Dry runs for PRs +permissions: + contents: read on: pull_request: branches: [devel] jobs: build: runs-on: ubuntu-latest + timeout-minutes: 60 steps:Adjust the
timeout-minutesvalue based on your expected build duration.
8-18: Consider adding dependency caching for performance.Caching R packages and Bioconductor dependencies can significantly improve CI runtime, especially if the workflow runs frequently.
Apply this diff to add caching before dependency installation:
steps: - name: Checkout repository uses: actions/checkout@v4 + - name: Cache R packages + uses: actions/cache@v4 + with: + path: ${{ env.R_LIBS_USER }} + key: ${{ runner.os }}-r-${{ hashFiles('DESCRIPTION') }} + restore-keys: ${{ runner.os }}-r- - name: Setup R and Bioconductor uses: grimbough/bioc-actions/setup-bioc@v1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/dry-run-build.yml(1 hunks)
🔇 Additional comments (2)
.github/workflows/dry-run-build.yml (2)
1-18: Workflow structure is sound.The workflow follows standard GitHub Actions patterns for Bioconductor CI checks. The steps are logically sequenced and use appropriate, version-pinned actions for reproducibility.
11-14: Action versions are current and actively maintained.All actions in the workflow are actively developed and their versions are appropriate:
actions/checkout@v4is the current GitHub official actiongrimbough/bioc-actions/setup-bioc@v1andbuild-install-check@v1are maintained by the Bioconductor team (latest repository update: Nov 13, 2025); v1 is the current version for these actionsr-lib/actions/setup-r-dependencies@v2is the recommended version (latest v2.11.4 released Oct 8, 2025)Binding to major version tags (v1, v2, v4) is GitHub Actions best practice and ensures your workflows automatically receive bug fixes and security patches within the specified major version. No deprecation or maintenance concerns apply here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.