Conversation
|
Albert, there are many files / lines modified in this pull request where the change is replacing single quotes with double quotes. While we never declared a standard, our existing code in the driver uses single quotes, so we'd like to keep this the same for consistency. Can you revert all of those changes, that will make it easier for us to review the consequential changes in this request. Thanks! |
|
Sure, if you find any other convention difference I'll change it to the convention you guys use. |
|
Now that you mention, I think the /tests had the double quotes and defined a .eslintrc with a double quote rule. If it's ok with you, I'll change the /tests to use sinlge quotes too. |
|
Yes, that would be great. It will help make the project more consistent. |
…on to leave like the original to localhost
No reconection when database closes socket.
2 participants
Most of the async operations are modified to return promises.
VoltTable support as a parameter ( volttable class in lib/volttable.js ).
Reconnect Capabilities.
More tests.
Hashinator implementation.
Sugar methods for: adHoc, updateClasses, systemOverview and others.