Open
Conversation
and probably making a mess...Committing everything and probably making a mess...Committing everything and probably making a mess...Committing everything and probably making a mess...Committing everything and probably making a mess...Committing everything and probably making a mess...Committing everything and probably making a mess...Committing everything and probably making a mess...
- Fix a sign in the unc. symmetrization for the postfit pdf grids maker - Fix a bug where the central value was incorrectly paired with other variations, leading to a mismatch for the assymetric uncertainties With these fixes the Rabbit and Grids-based plots agree very well
Make the postfit grids maker able to read from rabbit or from a more generic hdf5 format. Also implement a writer to make this simpler format. The idea is to have the code work in a way that is easier to share with theorists (or possibly the EWWG)
Collaborator
Author
|
From my perspective it would be good to have this reviewed and merged in, unless there are strong preferences for me to break it off into a separate package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.