Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

feat: read/unread status - #1376

Merged
chris13524 merged 26 commits into
mainfrom
feat/web3inbox-read-unread
Apr 17, 2024
Merged

feat: read/unread status#1376
chris13524 merged 26 commits into
mainfrom
feat/web3inbox-read-unread

Conversation

@chris13524

@chris13524 chris13524 commented Jan 31, 2024

Copy link
Copy Markdown
Member

Proposed documentation for the read/unread support in Web3Inbox. This feature has not been implemented yet, but the documentation here should be accurate to what will be built.

Open questions:

  • markAsUnread
  • UpdateNotificationsReadState vs markNotificationAsRead

Remaining work:

  • iOS docs
  • Complete changelog page
  • Feature implementation

@vercel

vercel Bot commented Jan 31, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walletconnect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:02pm
walletconnect-docs-alpha ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2024 7:02pm

Elyniss and others added 5 commits February 6, 2024 11:53
Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
…skeleton

feat: read/unread status skeleton and kotlin implementation
* chore: add api for read unread

* chore: remove all flag

* chore: add docs for vanilla

* chore: change mark as read to promise

* Update docs/api/notify/usage.mdx

Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>

* Update docs/web3inbox/frontend-integration/api.mdx

Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>

* chore: avoid negatives

* chore: add docs for react native

---------

Co-authored-by: Chris Smith <1979423+chris13524@users.noreply.github.com>
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3wallet/notify/usage.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated

@chris13524 chris13524 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devceline look good?

Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3wallet/notify/usage.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
Comment thread docs/web3inbox/frontend-integration/api.mdx Outdated
@chris13524
chris13524 marked this pull request as ready for review April 15, 2024 21:04
@vercel
vercel Bot temporarily deployed to Preview – walletconnect-docs April 16, 2024 09:30 Inactive
@vercel
vercel Bot temporarily deployed to Preview – walletconnect-docs-alpha April 16, 2024 09:31 Inactive

@devceline devceline left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel
vercel Bot temporarily deployed to Preview – walletconnect-docs-alpha April 16, 2024 18:56 Inactive
@vercel
vercel Bot temporarily deployed to Preview – walletconnect-docs April 16, 2024 18:56 Inactive
@chris13524

Copy link
Copy Markdown
Member Author

Wallet support extracted into a separate PR since it has not been implemented yet: #1535

@vercel
vercel Bot temporarily deployed to Preview – walletconnect-docs-alpha April 16, 2024 19:02 Inactive
@chris13524
chris13524 requested a review from glitch-txs April 16, 2024 19:02
@vercel
vercel Bot temporarily deployed to Preview – walletconnect-docs April 16, 2024 19:02 Inactive
@chris13524
chris13524 merged commit 642ce7f into main Apr 17, 2024
@chris13524
chris13524 deleted the feat/web3inbox-read-unread branch April 17, 2024 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants