Skip to content

Fix i32 sign extension in MemoryPacking pass #8368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumleo wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

Fix i32 sign extension in MemoryPacking pass #8368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/passes/MemoryPacking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,15 +455,15 @@ void MemoryPacking::optimizeSegmentOps(Module* module) {
bool mustTrap = false;
auto* offset = curr->offset->dynCast<Const>();
auto* size = curr->size->dynCast<Const>();
if (offset && uint32_t(offset->value.geti32()) > maxRuntimeSize) {
if (offset && offset->value.getUnsigned() > maxRuntimeSize) {
mustTrap = true;
}
if (size && uint32_t(size->value.geti32()) > maxRuntimeSize) {
if (size && size->value.getUnsigned() > maxRuntimeSize) {
mustTrap = true;
}
if (offset && size) {
uint64_t offsetVal(offset->value.geti32());
uint64_t sizeVal(size->value.geti32());
auto offsetVal = offset->value.getUnsigned();
auto sizeVal = size->value.getUnsigned();
if (offsetVal + sizeVal > maxRuntimeSize) {
mustTrap = true;
} else if (offsetVal == 0 && sizeVal == 0) {
Expand Down Expand Up @@ -710,8 +710,8 @@ void MemoryPacking::createReplacements(Module* module,
}

// Nonconstant offsets or sizes will have inhibited splitting
size_t start = init->offset->cast<Const>()->value.geti32();
size_t end = start + init->size->cast<Const>()->value.geti32();
size_t start = init->offset->cast<Const>()->value.getUnsigned();
size_t end = start + init->size->cast<Const>()->value.getUnsigned();

// Index in `segments` of the segment used in emitted memory.init
// instructions
Expand Down
Loading